public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Leah Rumancik <lrumancik@google.com>, Eryu Guan <guaneryu@gmail.com>
Cc: fstests <fstests@vger.kernel.org>, xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] generic/273: use _get_file_block_size
Date: Mon, 24 Jan 2022 10:37:35 -0800	[thread overview]
Message-ID: <20220124183735.GJ13563@magnolia> (raw)

From: Darrick J. Wong <djwong@kernel.org>

This test calculates the amount of free space on a filesystem and uses
the block size to spread the work of filling the free space among a
bunch of threads.  Unfortunately, the test /should/ be using the
allocation unit size, not the fs block size, which is why this test
fails on configurations such as XFS realtime with a 28k extent size.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
NOTE: This patch seems to fix the "porter not complete" problems on
5.16, but not on 5.17-rc1.  However, 5.17-rc1 is totally broken (~72%
failure rate) so I don't think I can count that as a serious QA effort.
---
 tests/generic/273 |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/generic/273 b/tests/generic/273
index b5458a77..f86dae9b 100755
--- a/tests/generic/273
+++ b/tests/generic/273
@@ -87,8 +87,8 @@ _do_workload()
 {
 	_pids=""
 	_pid=1
-	block_size=$(_get_block_size $SCRATCH_MNT)
-	
+	block_size=$(_get_file_block_size $SCRATCH_MNT)
+
 	_threads_set
 	_file_create $block_size
 

             reply	other threads:[~2022-01-24 18:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 18:37 Darrick J. Wong [this message]
2022-01-24 23:21 ` [PATCH] generic/273: use _get_file_block_size Leah Rumancik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220124183735.GJ13563@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=lrumancik@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox