From: Sun Ke <sunke32@huawei.com>
To: <fstests@vger.kernel.org>, <guan@eryu.me>
Cc: <chao@kernel.org>, <sunke32@huawei.com>
Subject: [PATCH] common/attr: _acl_get_max echo 532 for f2fs
Date: Sun, 30 Jan 2022 17:28:58 +0800 [thread overview]
Message-ID: <20220130092858.1260210-1-sunke32@huawei.com> (raw)
Run generic/026 on f2fs, the diff:
-chacl: cannot set access acl on "largeaclfile": Argument list too long
+Wrong ACL count - 532 != 531
The ACL_MAX_ENTRIES depend on MAX_VALUE_LEN(inode), MAX_VALUE_LEN(inode) I got
by printk is 4244, so I think the ACL_MAX_ENTRIES should be
(4244 - 20) / 8 + 4 =532.
Signed-off-by: Sun Ke <sunke32@huawei.com>
---
common/attr | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/attr b/common/attr
index 35682d7c..56ac5cca 100644
--- a/common/attr
+++ b/common/attr
@@ -28,7 +28,7 @@ _acl_get_max()
f2fs)
_fs_options $TEST_DEV | grep "inline_xattr" >/dev/null 2>&1
if [ $? -eq 0 ]; then
- echo 531
+ echo 532
else
echo 506
fi
--
2.13.6
next reply other threads:[~2022-01-30 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 9:28 Sun Ke [this message]
2022-01-30 15:07 ` [PATCH] common/attr: _acl_get_max echo 532 for f2fs Chao Yu
2022-02-01 17:53 ` Eric Biggers
2022-02-03 14:30 ` Chao Yu
2022-02-07 3:07 ` Sun Ke
2022-02-07 15:46 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220130092858.1260210-1-sunke32@huawei.com \
--to=sunke32@huawei.com \
--cc=chao@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox