From: Christian Brauner <brauner@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Eryu Guan <guan@eryu.me>,
fstests@vger.kernel.org,
Ariadne Conill <ariadne@dereferenced.org>,
Rich Felker <dalias@libc.org>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Eryu Guan <guaneryu@gmail.com>
Subject: Re: [PATCH] generic/633: adapt execveat() invocations
Date: Tue, 1 Feb 2022 14:31:03 +0100 [thread overview]
Message-ID: <20220201133103.bnqplswevdsdsjfv@wittgenstein> (raw)
In-Reply-To: <202201311245.0B2126B468@keescook>
On Mon, Jan 31, 2022 at 12:46:27PM -0800, Kees Cook wrote:
> On Mon, Jan 31, 2022 at 06:10:23PM +0100, Christian Brauner wrote:
> > There's a push by Ariadne to enforce that argv[0] cannot be NULL. So far
> > we've allowed this. Fix the execveat() invocations to set argv[0] to the
> > name of the file we're about to execute.
>
> To be clear, these tests are also trying to launch set-id binaries with
> argc == 0, so narrowing the kernel check to only set-id binaries
> wouldn't help here, yes?
Yes, that wouldn't help.
The new approach of mutating argv { NULL } into { "", NULL } is better.
next prev parent reply other threads:[~2022-02-01 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 17:10 [PATCH] generic/633: adapt execveat() invocations Christian Brauner
2022-01-31 20:46 ` Kees Cook
2022-02-01 13:31 ` Christian Brauner [this message]
2022-02-02 8:36 ` David Laight
2022-02-02 9:53 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201133103.bnqplswevdsdsjfv@wittgenstein \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ariadne@dereferenced.org \
--cc=dalias@libc.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox