From: Luis Chamberlain <mcgrof@kernel.org>
To: raymond.barbiero.dev@gmail.com
Cc: fstests@vger.kernel.org, jack@suse.cz,
mgorman@techsingularity.net, dave@stgolabs.net,
Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 12/25] child: be expicit about string truncation goal
Date: Wed, 9 Feb 2022 14:25:57 -0800 [thread overview]
Message-ID: <20220209222610.438470-13-mcgrof@kernel.org> (raw)
In-Reply-To: <20220209222610.438470-1-mcgrof@kernel.org>
Fix this compilation warning:
child.c:260:9: warning: ‘strncpy’ specified bound 256 equals destination
size [-Wstringop-truncation]
260 | strncpy(str, pstart, sizeof(str));
We do this by being explicit about our goal to truncate or use
the smaller string passed.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
child.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/child.c b/child.c
index d340860..2545e4c 100644
--- a/child.c
+++ b/child.c
@@ -251,13 +251,17 @@ static int parse_randomstring(char *line)
char *pstart, *pend, rndc[2];
unsigned int idx;
char str[256];
+ size_t min_len;
again:
pstart = index(line, '[');
if (pstart == NULL) {
goto finished;
}
- strncpy(str, pstart, sizeof(str));
+
+ /* Truncate or use the smaller size passed */
+ min_len = strlen(line) < sizeof(str) ? strlen(line) : sizeof(str);
+ strncpy(str, pstart, min_len);
pend = index(str, ']');
if (pstart == NULL) {
--
2.34.1
next prev parent reply other threads:[~2022-02-09 22:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 22:25 [PATCH 00/25] dbench: fix compile warnings and update a bit Luis Chamberlain
2022-02-09 22:25 ` [PATCH 01/25] dbench: simplify open_loadfile() as check_loadfile_ok() Luis Chamberlain
2022-02-09 22:25 ` [PATCH 02/25] child: fix usage of gzFile and gzopen() Luis Chamberlain
2022-02-09 22:25 ` [PATCH 03/25] dbench: remove unused double t value Luis Chamberlain
2022-02-09 22:25 ` [PATCH 04/25] child: fix data type comparison on child_run Luis Chamberlain
2022-02-09 22:25 ` [PATCH 05/25] Makefile.in: disable unused warning for rpc generated code Luis Chamberlain
2022-02-09 22:25 ` [PATCH 06/25] configure.ac: run autoupdate Luis Chamberlain
2022-02-09 22:25 ` [PATCH 07/25] dbench: update use of time.h or sys/time.h Luis Chamberlain
2022-02-09 22:25 ` [PATCH 08/25] config.h.in: run autoconf Luis Chamberlain
2022-02-09 22:25 ` [PATCH 09/25] snprintf: specify safe fallthrough on switches Luis Chamberlain
2022-02-09 22:25 ` [PATCH 10/25] nfsio.c: include dbench.h before nfs.h Luis Chamberlain
2022-02-09 22:25 ` [PATCH 11/25] nfsio: remove unused status variable Luis Chamberlain
2022-02-09 22:25 ` Luis Chamberlain [this message]
2022-02-09 22:25 ` [PATCH 13/25] child: do not overlap on memcpy() Luis Chamberlain
2022-02-09 22:25 ` [PATCH 14/25] dbench.h: use bits/types.h instead of defining uint32 Luis Chamberlain
2022-02-09 22:26 ` [PATCH 15/25] sockio.c: use uint32_t Luis Chamberlain
2022-02-09 22:26 ` [PATCH 16/25] libnfs.c: fix a few simple compile warnings Luis Chamberlain
2022-02-09 22:26 ` [PATCH 17/25] libnfs: fix compilation warning for inet_tons Luis Chamberlain
2022-02-09 22:26 ` [PATCH 18/25] libnfs.c: fix sign conflict compile warning Luis Chamberlain
2022-02-09 22:26 ` [PATCH 19/25] Makefile.in: Luis Chamberlain
2022-02-09 22:26 ` [PATCH 20/25] linux_scsi.c: fix redeclaration of _GNU_SOURCE Luis Chamberlain
2022-02-09 22:26 ` [PATCH 21/25] Makefile.in: modernize build output with V=1 or V=0 Luis Chamberlain
2022-02-09 22:26 ` [PATCH 22/25] Makefile.in: declare datarootdir Luis Chamberlain
2022-02-09 22:26 ` [PATCH 23/25] configure.ac: fix smbclient detection Luis Chamberlain
2022-02-09 22:26 ` [PATCH 24/25] libiscsi: fix compile warning on data types Luis Chamberlain
2022-02-09 22:26 ` [PATCH 25/25] smb: fix compilation and disable warning on deprecated-declarations Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209222610.438470-13-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=dave@stgolabs.net \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=mgorman@techsingularity.net \
--cc=raymond.barbiero.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).