From: Andrey Albershteyn <aalbersh@redhat.com>
To: fstests@vger.kernel.org
Cc: Andrey Albershteyn <aalbersh@redhat.com>
Subject: [PATCH] ext4/053: check that remount with abort makes fs read-only
Date: Thu, 10 Mar 2022 12:18:11 +0100 [thread overview]
Message-ID: <20220310111810.14543-1-aalbersh@redhat.com> (raw)
The 6e47a3cc68fc ("ext4: get rid of super block and sbi from
handle_mount_ops()") broke abort mount option. That problem was not
detected by ext4/053.
This addition test checks that during aborted remount, filesystem
switches into read-only state (enabled by ext4_handle_error()
causing mount to fail).
Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
---
tests/ext4/053 | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/ext4/053 b/tests/ext4/053
index e1e79592..38f162a9 100755
--- a/tests/ext4/053
+++ b/tests/ext4/053
@@ -360,6 +360,10 @@ not_remount() {
$UMOUNT_PROG $SCRATCH_MNT 2> /dev/null
}
+mnt_not_remount() {
+ do_mnt
+ not_remount -r $@
+}
do_mkfs() {
$MKE2FS_PROG -T $fstype -Fq $* >> $seqres.full 2>&1 ||
@@ -450,6 +454,7 @@ for fstype in ext2 ext3 ext4; do
only_ext4 mnt nojournal_checksum
only_ext4 mnt journal_async_commit,data=writeback
mnt abort ignored
+ mnt_not_remount abort ignored
not_ext2 mnt -t data=journal
not_ext2 mnt -t data=ordered
not_ext2 mnt -t data=writeback
--
2.27.0
next reply other threads:[~2022-03-10 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 11:18 Andrey Albershteyn [this message]
2022-03-17 14:37 ` [PATCH] ext4/053: check that remount with abort makes fs read-only Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310111810.14543-1-aalbersh@redhat.com \
--to=aalbersh@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox