FS/XFS testing framework
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: fstests@vger.kernel.org
Cc: David Disseldorp <ddiss@suse.de>
Subject: [PATCH] common/attr: reduce MAX_ATTRVAL_SIZE for NFS
Date: Fri,  8 Apr 2022 21:19:43 +0200	[thread overview]
Message-ID: <20220408191943.27655-1-ddiss@suse.de> (raw)

When testing against an NFS export backed by a Btrfs filesystem,
generic/020 may fail, e.g.

  --- /xfstests/tests/generic/020.out
  +++ /xfstests/results/generic/020.out.bad
  @@ -47,9 +47,13 @@
   user.snrub="fish2\012"

   *** really long value
  -0000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  -*
  -ATTRSIZE
  +attr_set: No space left on device
  +Could not set "long_attr" for <TESTFILE>
  +attr_get: No data available
  +Could not get "long_attr" for <TESTFILE>
  +0000000
  +attr_remove: No data available
  +Could not remove "long_attr" for <TESTFILE>

This is due to the MAX_ATTRVAL_SIZE=65536 setting for NFS, which exceeds
the Btrfs (and XFS) limit of MAX_ATTRVAL_SIZE=64. Change NFS to use this
lower bound value.

Signed-off-by: David Disseldorp <ddiss@suse.de>
---
 common/attr | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/attr b/common/attr
index dae8a1bb..1778e8b2 100644
--- a/common/attr
+++ b/common/attr
@@ -319,13 +319,13 @@ export MAX_ATTRS
 
 # Set max attr value size based on fs type
 case "$FSTYP" in
-xfs|udf|btrfs)
+xfs|udf|btrfs|nfs)
 	MAX_ATTRVAL_SIZE=64
 	;;
 pvfs2)
 	MAX_ATTRVAL_SIZE=8192
 	;;
-9p|ceph|nfs)
+9p|ceph)
 	MAX_ATTRVAL_SIZE=65536
 	;;
 bcachefs)
-- 
2.34.1


             reply	other threads:[~2022-04-08 19:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08 19:19 David Disseldorp [this message]
2022-04-11  5:47 ` [PATCH] common/attr: reduce MAX_ATTRVAL_SIZE for NFS Dave Chinner
2022-04-11  8:57   ` David Disseldorp
2022-04-11 22:29     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220408191943.27655-1-ddiss@suse.de \
    --to=ddiss@suse.de \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox