public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Zorro Lang <zlang@redhat.com>, Eryu Guan <guaneryu@gmail.com>
Cc: fstests@vger.kernel.org
Subject: [PATCH v2 0/2] Annonate fstests with possible reasons for failure
Date: Tue, 19 Apr 2022 15:56:35 +0300	[thread overview]
Message-ID: <20220419125637.2502181-1-amir73il@gmail.com> (raw)

Zorro,

This series adresses your review comments on v1.
Specifically, I dropped the controversial patch #3 and the
SKIP_KNOWN_ISSUES run option.

To clarify, multiple annotations could be used in each test,
for example:
 _fixed_by_kernel_commit 09889695864 xfs: foo
 _fixed_by_kernel_commit 46464565465 ext4: bar
 _fixed_by_git_commit e2fsprogs 62464626 e2fs: baz
 _fixed_in_version xfsprogs v5.15

On test failure, all the hints will be printed to output as *possible*
reason for failure.

These annotation and printed hints are inspired by a similar LTP feature.

These annotation could be used by testers to auto-generate expunge list
for testing stable kernels from the information in _fixed_by_kernel_commit
and _fixed_in_kernel_version. This trivial task is left is an excercise.

Thanks,
Amir.

Changes since v1:
- Rename s/_known_issue_before_kernel/_fixed_in_kernel_version (zlang)
- Add generic helpers for non-kernel fixes (zlang)
- Drop _known_issue_on_fs (zlang)
- Clarify multiple hints are allowed (tytso)

Amir Goldstein (2):
  common: support black listing fs in _supported_fs()
  common: print hints for reasons of test failures

 check             | 10 ++++++++-
 common/preamble   |  2 +-
 common/rc         | 57 +++++++++++++++++++++++++++++++++++++++--------
 tests/generic/500 |  3 +--
 tests/generic/631 |  3 +--
 tests/generic/679 |  3 +--
 tests/overlay/009 |  3 +++
 tests/overlay/010 |  3 +++
 tests/overlay/014 |  2 ++
 tests/overlay/016 |  4 +++-
 tests/overlay/017 |  4 +++-
 tests/overlay/018 |  4 +++-
 tests/overlay/020 |  3 +++
 tests/overlay/022 |  2 ++
 tests/overlay/029 |  2 ++
 tests/overlay/038 |  2 ++
 tests/overlay/041 |  2 ++
 tests/overlay/042 |  3 +++
 tests/overlay/043 |  4 +++-
 tests/overlay/044 |  4 +++-
 tests/overlay/054 |  3 +++
 tests/overlay/055 |  3 +++
 tests/overlay/063 |  3 +++
 tests/overlay/065 |  4 ++++
 tests/overlay/067 |  3 +++
 tests/overlay/070 |  4 +++-
 tests/overlay/071 |  4 +++-
 tests/overlay/072 |  2 ++
 tests/overlay/074 |  5 +++++
 tests/overlay/077 |  5 +++++
 tests/overlay/078 |  1 +
 31 files changed, 133 insertions(+), 24 deletions(-)

-- 
2.25.1


             reply	other threads:[~2022-04-19 12:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 12:56 Amir Goldstein [this message]
2022-04-19 12:56 ` [PATCH v2 1/2] common: support black listing fs in _supported_fs() Amir Goldstein
2022-04-19 12:56 ` [PATCH v2 2/2] common: print hints for reasons of test failures Amir Goldstein
2022-05-02  4:04 ` [PATCH v2 0/2] Annonate fstests with possible reasons for failure Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220419125637.2502181-1-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox