From: Dave Chinner <david@fromorbit.com>
To: Nathan Huckleberry <nhuck@google.com>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [RFC PATCH v2 2/2] generic: add tests for fscrypt policies with HCTR2
Date: Fri, 6 May 2022 07:45:29 +1000 [thread overview]
Message-ID: <20220505214529.GC1949718@dread.disaster.area> (raw)
In-Reply-To: <20220505193809.579026-3-nhuck@google.com>
On Thu, May 05, 2022 at 02:38:09PM -0500, Nathan Huckleberry wrote:
> This patch adds fscrypt policy tests for filename encryption using
> HCTR2.
>
> More information on HCTR2 can be found here: "Length-preserving
> encryption with HCTR2" https://ia.cr/2021/1441
One test for all three verifications would be better - less tests to
run, less tests to maintain. Especially as these are effectively
one-line tests with a clear golden output which tells us exactly
which verification failed...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2022-05-05 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 19:38 [RFC PATCH v2 0/2] generic: test HCTR2 filename encryption Nathan Huckleberry
2022-05-05 19:38 ` [RFC PATCH v2 1/2] fscrypt-crypt-util: add HCTR2 reference implementation Nathan Huckleberry
2022-05-05 19:38 ` [RFC PATCH v2 2/2] generic: add tests for fscrypt policies with HCTR2 Nathan Huckleberry
2022-05-05 21:45 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505214529.GC1949718@dread.disaster.area \
--to=david@fromorbit.com \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=nhuck@google.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox