FS/XFS testing framework
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: zlang@kernel.org
Cc: fstests@vger.kernel.org, Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: [PATCH] casefold: Fix expansion of seqres variable
Date: Tue, 10 May 2022 20:25:20 -0400	[thread overview]
Message-ID: <20220511002520.352812-1-krisman@collabora.com> (raw)

seqres is not properly expanded on these error paths, causing a file
called seqres.full to be created instead.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
---
 common/casefold | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/casefold b/common/casefold
index 9172d818125a..7e8f941211db 100644
--- a/common/casefold
+++ b/common/casefold
@@ -25,7 +25,7 @@ _require_scratch_casefold()
 		_notrun "$FSTYP does not support casefold feature"
 	fi
 
-	if ! _scratch_mkfs_casefold &>>seqres.full; then
+	if ! _scratch_mkfs_casefold &>>$seqres.full; then
 		_notrun "$FSTYP userspace tools do not support casefold"
 	fi
 
@@ -33,7 +33,7 @@ _require_scratch_casefold()
 	# defined by the userspace tools.  This will fail if
 	# the userspace tool used a more recent encoding than the one
 	# supported in kernel space.
-	if ! _try_scratch_mount &>>seqres.full; then
+	if ! _try_scratch_mount &>>$seqres.full; then
 		_notrun "kernel can't mount filesystem with the encoding set by userspace"
 	fi
 	_scratch_unmount
-- 
2.35.3


             reply	other threads:[~2022-05-11  0:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11  0:25 Gabriel Krisman Bertazi [this message]
2022-05-11  4:55 ` [PATCH] casefold: Fix expansion of seqres variable Dave Chinner
2022-05-11  9:26   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220511002520.352812-1-krisman@collabora.com \
    --to=krisman@collabora.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox