From: Dave Chinner <david@fromorbit.com>
To: fstests@vger.kernel.org
Subject: [PATCH 8/8] fstests: cleanup _cleanup usage in shared
Date: Tue, 24 May 2022 17:34:11 +1000 [thread overview]
Message-ID: <20220524073411.1943480-9-david@fromorbit.com> (raw)
In-Reply-To: <20220524073411.1943480-1-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
To match the cleanup of tests/xfs
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
tests/shared/002 | 7 ++++---
tests/shared/298 | 22 +++++++++++-----------
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/tests/shared/002 b/tests/shared/002
index d99539c9..0a92dcc2 100755
--- a/tests/shared/002
+++ b/tests/shared/002
@@ -15,12 +15,13 @@
. ./common/preamble
_begin_fstest auto metadata quick log
-# Override the default cleanup function.
-_cleanup()
+_dmflakey_cleanup()
{
+ _unmount_flakey
_cleanup_flakey
- rm -f $tmp.*
+ _cleanup
}
+_register_cleanup _dmflakey_cleanup
# Import common functions.
. ./common/filter
diff --git a/tests/shared/298 b/tests/shared/298
index bd52b6a0..797ac7a8 100755
--- a/tests/shared/298
+++ b/tests/shared/298
@@ -9,6 +9,17 @@
. ./common/preamble
_begin_fstest auto trim
+_loop_cleanup()
+{
+ UMOUNT_PROG $loop_dev &> /dev/null
+ _destroy_loop_device $loop_dev
+ if [ $status -eq 0 ]; then
+ rm $img_file
+ fi
+ _cleanup
+}
+_register_cleanup _loop_cleanup
+
_supported_fs ext4 xfs btrfs
_require_test
_require_loop
@@ -27,17 +38,6 @@ fi
[ "$FSTYP" = "btrfs" ] && _require_btrfs_command inspect-internal dump-super
[ "$FSTYP" = "btrfs" ] && _require_btrfs_command inspect-internal dump-tree
-# Override the default cleanup function.
-_cleanup()
-{
- $UMOUNT_PROG $loop_dev &> /dev/null
- _destroy_loop_device $loop_dev
- if [ $status -eq 0 ]; then
- rm -rf $tmp
- rm $img_file
- fi
-}
-
get_holes()
{
# It's not a good idea to be running tools against the image file
--
2.35.1
next prev parent reply other threads:[~2022-05-24 7:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:34 [RFC PATCH 0/8] fstests: _cleanup() overrides are a mess Dave Chinner
2022-05-24 7:34 ` [PATCH 1/8] generic/038: kill background threads on interrupt Dave Chinner
2022-05-24 9:41 ` Amir Goldstein
2022-05-24 12:10 ` Dave Chinner
2022-05-24 12:30 ` Amir Goldstein
2022-05-24 7:34 ` [PATCH 2/8] fstests: _cleanup overrides are messy Dave Chinner
2022-05-24 16:16 ` Amir Goldstein
2022-05-24 7:34 ` [PATCH 3/8] xfs/*: clean up _cleanup override Dave Chinner
2022-05-24 10:42 ` Amir Goldstein
2022-05-24 12:27 ` Dave Chinner
2022-05-24 12:55 ` Amir Goldstein
2022-05-24 13:24 ` Dave Chinner
2022-05-24 14:17 ` Amir Goldstein
2022-05-24 16:32 ` Zorro Lang
2022-05-24 23:34 ` Dave Chinner
2022-05-25 2:54 ` Amir Goldstein
2022-05-24 17:13 ` Zorro Lang
2022-05-26 15:04 ` Zorro Lang
2022-05-26 23:39 ` Dave Chinner
2022-05-24 7:34 ` [PATCH 4/8] fstests: define a common _dump_cleanup function Dave Chinner
2022-05-24 9:04 ` Amir Goldstein
2022-05-24 9:52 ` Dave Chinner
2022-05-24 9:59 ` Amir Goldstein
2022-05-24 7:34 ` [PATCH 5/8] fstests: use a common fsstress cleanup function Dave Chinner
2022-05-24 12:25 ` Amir Goldstein
2022-05-24 7:34 ` [PATCH 6/8] fstests: consolidate no cleanup test setup Dave Chinner
2022-05-24 12:22 ` Amir Goldstein
2022-05-24 13:07 ` Dave Chinner
2022-05-24 7:34 ` [PATCH 7/8] fstests: Set up BUS trap for tests by default Dave Chinner
2022-05-24 8:48 ` Amir Goldstein
2022-05-24 7:34 ` Dave Chinner [this message]
2022-05-24 10:49 ` [PATCH 8/8] fstests: cleanup _cleanup usage in shared Amir Goldstein
2022-05-24 11:11 ` Amir Goldstein
2022-05-24 8:29 ` [RFC PATCH 0/8] fstests: _cleanup() overrides are a mess Amir Goldstein
2022-05-24 9:57 ` Dave Chinner
2022-05-24 10:01 ` Amir Goldstein
2022-05-24 10:13 ` Dave Chinner
2022-05-24 12:14 ` Amir Goldstein
2022-05-24 12:28 ` Dave Chinner
2022-05-24 12:34 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524073411.1943480-9-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox