From: "Luís Henriques" <lhenriques@suse.de>
To: fstests@vger.kernel.org
Cc: "Dave Chinner" <david@fromorbit.com>,
"Darrick J. Wong" <djwong@kernel.org>,
"Jeff Layton" <jlayton@kernel.org>,
"Xiubo Li" <xiubli@redhat.com>,
ceph-devel@vger.kernel.org, "Luís Henriques" <lhenriques@suse.de>
Subject: [PATCH v2 1/2] generic/020: adjust max_attrval_size for ceph
Date: Thu, 9 Jun 2022 11:53:42 +0100 [thread overview]
Message-ID: <20220609105343.13591-2-lhenriques@suse.de> (raw)
In-Reply-To: <20220609105343.13591-1-lhenriques@suse.de>
CephFS doesn't have a maximum xattr size. Instead, it imposes a maximum
size for the full set of xattrs names+values, which by default is 64K.
This patch fixes the max_attrval_size so that it is slightly < 64K in
order to accommodate any already existing xattrs in the file.
Signed-off-by: Luís Henriques <lhenriques@suse.de>
---
tests/generic/020 | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/generic/020 b/tests/generic/020
index d8648e96286e..76f13220fe85 100755
--- a/tests/generic/020
+++ b/tests/generic/020
@@ -128,7 +128,7 @@ _attr_get_max()
pvfs2)
max_attrval_size=8192
;;
- xfs|udf|9p|ceph)
+ xfs|udf|9p)
max_attrval_size=65536
;;
bcachefs)
@@ -139,6 +139,14 @@ _attr_get_max()
# the underlying filesystem, so just use the lowest value above.
max_attrval_size=1024
;;
+ ceph)
+ # CephFS does not have a maximum value for attributes. Instead,
+ # it imposes a maximum size for the full set of xattrs
+ # names+values, which by default is 64K. Set this to a value
+ # that is slightly smaller than 64K so that it can accommodate
+ # already existing xattrs.
+ max_attrval_size=65000
+ ;;
*)
# Assume max ~1 block of attrs
BLOCK_SIZE=`_get_block_size $TEST_DIR`
next prev parent reply other threads:[~2022-06-09 10:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 10:53 [PATCH v2 0/2] Two xattrs-related fixes for ceph Luís Henriques
2022-06-09 10:53 ` Luís Henriques [this message]
2022-06-09 14:21 ` [PATCH v2 1/2] generic/020: adjust max_attrval_size " David Disseldorp
2022-06-09 14:54 ` Luís Henriques
2022-06-09 22:00 ` David Disseldorp
2022-06-10 13:01 ` Luis Henriques
2022-06-10 0:47 ` Xiubo Li
2022-06-10 13:06 ` Luis Henriques
2022-06-09 10:53 ` [PATCH v2 2/2] generic/486: adjust the max xattr size Luís Henriques
2022-06-10 5:35 ` Xiubo Li
2022-06-10 7:25 ` Dave Chinner
2022-06-10 9:19 ` Zorro Lang
2022-06-10 13:08 ` Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609105343.13591-2-lhenriques@suse.de \
--to=lhenriques@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=jlayton@kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox