From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD7CC433EF for ; Fri, 10 Jun 2022 06:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244049AbiFJGAj (ORCPT ); Fri, 10 Jun 2022 02:00:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238858AbiFJGAi (ORCPT ); Fri, 10 Jun 2022 02:00:38 -0400 Received: from out20-98.mail.aliyun.com (out20-98.mail.aliyun.com [115.124.20.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 589E912FB2C for ; Thu, 9 Jun 2022 23:00:35 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.05394777|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_regular_dialog|0.0309049-0.00207913-0.967016;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047198;MF=wangyugui@e16-tech.com;NM=1;PH=DS;RN=2;RT=2;SR=0;TI=SMTPD_---.O1U7kj5_1654840831; Received: from 192.168.2.112(mailfrom:wangyugui@e16-tech.com fp:SMTPD_---.O1U7kj5_1654840831) by smtp.aliyun-inc.com; Fri, 10 Jun 2022 14:00:31 +0800 Date: Fri, 10 Jun 2022 14:00:35 +0800 From: Wang Yugui To: Zorro Lang Subject: Re: [PATCH] generic/297: fix the delta time based on stat Cc: fstests@vger.kernel.org In-Reply-To: <20220610051926.75oiyafys56dfdy3@zlang-mailbox> References: <20220610123623.D773.409509F4@e16-tech.com> <20220610051926.75oiyafys56dfdy3@zlang-mailbox> Message-Id: <20220610140034.949C.409509F4@e16-tech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.75.04 [en] Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org Hi, > On Fri, Jun 10, 2022 at 12:36:24PM +0800, Wang Yugui wrote: > > Hi, > > > > > On Fri, Jun 10, 2022 at 10:35:53AM +0800, Wang Yugui wrote: > > > > stat -c '%Y' report seconds as int, so the delta 2.01s may result as 3s. > > > > > > > > Signed-off-by: Wang Yugui > > > > --- > > > > tests/generic/297 | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/tests/generic/297 b/tests/generic/297 > > > > index 6bdc3e1c..e3082202 100755 > > > > --- a/tests/generic/297 > > > > +++ b/tests/generic/297 > > > > @@ -51,7 +51,7 @@ for i in $(seq 0 $fnr); do > > > > touch $TEST_DIR/after > > > > before=$(stat -c '%Y' $TEST_DIR/before) > > > > after=$(stat -c '%Y' $TEST_DIR/after) > > > > - delta=$((after - before)) > > > > + delta=$((after - before -1)) # 2.01s may result as 3s; so -1 > > > > > > What issue is this change trying to fix? "timeout=8"s is not long enough? > > > > for the command > > $TIMEOUT_PROG -s INT ${kill_after}s > > > > delta=$((after - before )) may report 'kill_after+1' in some case. > > > > so no relationship to "timeout=8" or "timeout=2". > > > > '$XFS_IO_PROG -f -c reflink' without '$TIMEOUT_PROG -s INT ${kill_after}s' > > may take 20s because this is a very complex reflink. > > Hmm... still don't understand what are you trying to fix. > > That reflink operation need long time, that's expected. The first time it's > running in a while loop for getting a proper testing size, no matter 8.01s > or 9s, I think it's all good. > > The second time the reflink run with `TIMEOUT_PROG 2s`, we expect it can be > killed in 'timeout=8s', that's long enough. I think it's not necessary to > care about it's keep running in 8.01s or 9s. drop this patch please. btrfs of generic/297 has a few freqency to fail. maybe because $XFS_IO_PROG is interrupt by timeout, but the reflink inside kernel continue to finish. Best Regards Wang Yugui (wangyugui@e16-tech.com) 2022/06/10