From: "Luís Henriques" <lhenriques@suse.de>
To: fstests@vger.kernel.org
Cc: "David Disseldorp" <ddiss@suse.de>,
"Zorro Lang" <zlang@redhat.com>,
"Dave Chinner" <david@fromorbit.com>,
"Darrick J. Wong" <djwong@kernel.org>,
"Jeff Layton" <jlayton@kernel.org>,
"Xiubo Li" <xiubli@redhat.com>,
ceph-devel@vger.kernel.org, "Luís Henriques" <lhenriques@suse.de>
Subject: [PATCH v3 0/2] Two xattrs-related fixes for ceph
Date: Mon, 13 Jun 2022 12:31:40 +0100 [thread overview]
Message-ID: <20220613113142.4338-1-lhenriques@suse.de> (raw)
Hi!
A bug fix in ceph has made some changes in the way xattr limits are
enforced on the client side. This requires some fixes on tests
generic/020 and generic/486.
* Changes since v2:
- patch 0001:
Add logic to compute the *real* maximum. Kudos to David Disseldorp
for providing the right incantation to do the maths. Also split
_attr_get_max() in two, so that they can be invoked from different
places in the test script.
- patch 002:
attr_replace_test now has an extra param as suggested by Dave Chinner,
and added fs-specific logic to the script. No need to have an exact
maximum in this test, a big-enough value suffices.
* Changes since v1:
- patch 0001:
Set the max size for xattrs values to a 65000, so that it is close to
the maximum, but still able to accommodate any pre-existing xattr
- patch 0002:
Same thing as patch 0001, but in a more precise way: actually take
into account the exact sizes for name+value of a pre-existing xattr.
Luís Henriques (2):
generic/020: adjust max_attrval_size for ceph
generic/486: adjust the max xattr size
src/attr_replace_test.c | 30 ++++++++++++++++++++++++++----
tests/generic/020 | 33 +++++++++++++++++++++++++--------
tests/generic/486 | 11 ++++++++++-
3 files changed, 61 insertions(+), 13 deletions(-)
next reply other threads:[~2022-06-13 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 11:31 Luís Henriques [this message]
2022-06-13 11:31 ` [PATCH v3 1/2] generic/020: adjust max_attrval_size for ceph Luís Henriques
2022-06-13 12:21 ` David Disseldorp
2022-06-13 11:31 ` [PATCH v3 2/2] generic/486: adjust the max xattr size Luís Henriques
2022-06-13 12:24 ` David Disseldorp
2022-06-14 9:22 ` [PATCH v3 0/2] Two xattrs-related fixes for ceph Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613113142.4338-1-lhenriques@suse.de \
--to=lhenriques@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=ddiss@suse.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=jlayton@kernel.org \
--cc=xiubli@redhat.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox