From: "Luís Henriques" <lhenriques@suse.de>
To: fstests@vger.kernel.org
Cc: "David Disseldorp" <ddiss@suse.de>,
"Zorro Lang" <zlang@redhat.com>,
"Jeff Layton" <jlayton@kernel.org>,
"Xiubo Li" <xiubli@redhat.com>,
ceph-devel@vger.kernel.org, "Luís Henriques" <lhenriques@suse.de>
Subject: [PATCH v2] ceph/005: verify correct statfs behaviour with quotas
Date: Wed, 15 Jun 2022 16:14:18 +0100 [thread overview]
Message-ID: <20220615151418.23805-1-lhenriques@suse.de> (raw)
When using a directory with 'max_bytes' quota as a base for a mount,
statfs shall use that 'max_bytes' value as the total disk size. That
value shall be used even when using subdirectory as base for the mount.
A bug was found where, when this subdirectory also had a 'max_files'
quota, the real filesystem size would be returned instead of the parent
'max_bytes' quota value. This test case verifies this bug is fixed.
Signed-off-by: Luís Henriques <lhenriques@suse.de>
---
Finally, I've managed to come back to this test. The major changes since
v1 are:
- creation of an helper for getting total mount space using 'df'
- now the test sends quota size to stdout
common/rc | 13 +++++++++++++
tests/ceph/005 | 38 ++++++++++++++++++++++++++++++++++++++
tests/ceph/005.out | 4 ++++
3 files changed, 55 insertions(+)
create mode 100755 tests/ceph/005
create mode 100644 tests/ceph/005.out
diff --git a/common/rc b/common/rc
index 2f31ca464621..72eabb7a428c 100644
--- a/common/rc
+++ b/common/rc
@@ -4254,6 +4254,19 @@ _get_available_space()
echo $((avail_kb * 1024))
}
+# get the total space in bytes
+#
+_get_total_space()
+{
+ if [ -z "$1" ]; then
+ echo "Usage: _get_total_space <mnt>"
+ exit 1
+ fi
+ local total_kb;
+ total_kb=`$DF_PROG $1 | tail -n1 | awk '{ print $3 }'`
+ echo $(($total_kb * 1024))
+}
+
# return device size in kb
_get_device_size()
{
diff --git a/tests/ceph/005 b/tests/ceph/005
new file mode 100755
index 000000000000..7eb687e8a092
--- /dev/null
+++ b/tests/ceph/005
@@ -0,0 +1,38 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2022 SUSE Linux Products GmbH. All Rights Reserved.
+#
+# FS QA Test 005
+#
+# Make sure statfs reports correct total size when:
+# 1. using a directory with 'max_byte' quota as base for a mount
+# 2. using a subdirectory of the above directory with 'max_files' quota
+#
+. ./common/preamble
+_begin_fstest auto quick quota
+
+_supported_fs ceph
+_require_scratch
+
+_scratch_mount
+mkdir -p "$SCRATCH_MNT/quota-dir/subdir"
+
+# set quota
+quota=$((2 ** 30)) # 1G
+$SETFATTR_PROG -n ceph.quota.max_bytes -v "$quota" "$SCRATCH_MNT/quota-dir"
+$SETFATTR_PROG -n ceph.quota.max_files -v "$quota" "$SCRATCH_MNT/quota-dir/subdir"
+_scratch_unmount
+
+SCRATCH_DEV="$SCRATCH_DEV/quota-dir" _scratch_mount
+echo ceph quota size is $(_get_total_space "$SCRATCH_MNT") bytes
+SCRATCH_DEV="$SCRATCH_DEV/quota-dir" _scratch_unmount
+
+SCRATCH_DEV="$SCRATCH_DEV/quota-dir/subdir" _scratch_mount
+echo subdir ceph quota size is $(_get_total_space "$SCRATCH_MNT") bytes
+SCRATCH_DEV="$SCRATCH_DEV/quota-dir/subdir" _scratch_unmount
+
+echo "Silence is golden"
+
+# success, all done
+status=0
+exit
diff --git a/tests/ceph/005.out b/tests/ceph/005.out
new file mode 100644
index 000000000000..47798b1fcd6f
--- /dev/null
+++ b/tests/ceph/005.out
@@ -0,0 +1,4 @@
+QA output created by 005
+ceph quota size is 1073741824 bytes
+subdir ceph quota size is 1073741824 bytes
+Silence is golden
next reply other threads:[~2022-06-15 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 15:14 Luís Henriques [this message]
2022-06-25 15:06 ` [PATCH v2] ceph/005: verify correct statfs behaviour with quotas Zorro Lang
2022-06-27 0:35 ` Xiubo Li
2022-06-27 9:20 ` Luís Henriques
2022-06-27 9:35 ` Xiubo Li
2022-06-27 10:25 ` Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615151418.23805-1-lhenriques@suse.de \
--to=lhenriques@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
--cc=jlayton@kernel.org \
--cc=xiubli@redhat.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox