Re: [PATCH v2 0/2] Fix input value to _scratch_mkfs_sized

Dave Chinner
2022-06-17T03:58:44Z

On Thu, Jun 16, 2022 at 12:38:43PM +0800, An Long wrote:
> Function _scratch_mkfs_sized cannot recognize the size descriptor.
>
> For example, we set MKFS_OPTIONS="-b 4k" and then run generic/416 on
> ext4, will fail with "mkfs.ext4: invalid block size - 4".

So isn't the correct fix for this to use the correct format in
MKFS_OPTIONS? ie. "-b 4096"?

i.e. why do we need ito add code to fix something that the user must
specify themselves and could easily just use an integer to begin
with?

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com