From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B237C43334 for ; Fri, 17 Jun 2022 03:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232836AbiFQD6n (ORCPT ); Thu, 16 Jun 2022 23:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231650AbiFQD6l (ORCPT ); Thu, 16 Jun 2022 23:58:41 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 17CE666688 for ; Thu, 16 Jun 2022 20:58:41 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 182C55ECB03; Fri, 17 Jun 2022 13:58:38 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1o2380-007ahc-LL; Fri, 17 Jun 2022 13:58:36 +1000 Date: Fri, 17 Jun 2022 13:58:36 +1000 From: Dave Chinner To: An Long Cc: fstests@vger.kernel.org Subject: Re: [PATCH v2 0/2] Fix input value to _scratch_mkfs_sized Message-ID: <20220617035836.GZ1098723@dread.disaster.area> References: <20220616043845.14320-1-lan@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616043845.14320-1-lan@suse.com> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=e9dl9Yl/ c=1 sm=1 tr=0 ts=62abfbef a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=JPEYwPQDsx4A:10 a=7-415B0cAAAA:8 a=OIkrDSTBtBtnZ0NAmicA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Thu, Jun 16, 2022 at 12:38:43PM +0800, An Long wrote: > Function _scratch_mkfs_sized cannot recognize the size descriptor. > > For example, we set MKFS_OPTIONS="-b 4k" and then run generic/416 on > ext4, will fail with "mkfs.ext4: invalid block size - 4". So isn't the correct fix for this to use the correct format in MKFS_OPTIONS? ie. "-b 4096"? i.e. why do we need ito add code to fix something that the user must specify themselves and could easily just use an integer to begin with? Cheers, Dave. -- Dave Chinner david@fromorbit.com