Re: [PATCH v2 0/2] Fix input value to _scratch_mkfs_sized

Zorro Lang
2022-06-17T17:52:23Z

On Fri, Jun 17, 2022 at 01:58:36PM +1000, Dave Chinner wrote:
> On Thu, Jun 16, 2022 at 12:38:43PM +0800, An Long wrote:
> > Function _scratch_mkfs_sized cannot recognize the size descriptor.
> >
> > For example, we set MKFS_OPTIONS="-b 4k" and then run generic/416 on
> > ext4, will fail with "mkfs.ext4: invalid block size - 4".
>
> So isn't the correct fix for this to use the correct format in
> MKFS_OPTIONS? ie. "-b 4096"?
>
> i.e. why do we need ito add code to fix something that the user must
> specify themselves and could easily just use an integer to begin
> with?

The fstests doesn't notice users that they *must* use pure number in
MKFS_OPTIONS, especially the block size.
As this issue, we have to accept the size unit(k/m/g ...) or have to
tell the users that they must use pure integer, any of "k/m/g" is
unacceptable. I prefer the former, so I'd like to have this change,
except anyone has a better idea :)

Thanks,
Zorro

>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
>