From: Amir Goldstein <amir73il@gmail.com>
To: Zorro Lang <zlang@redhat.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
fstests@vger.kernel.org
Subject: [PATCH v2 1/3] fstests: add missing _require_freeze() to tests
Date: Tue, 21 Jun 2022 20:37:27 +0300 [thread overview]
Message-ID: <20220621173729.2135249-2-amir73il@gmail.com> (raw)
In-Reply-To: <20220621173729.2135249-1-amir73il@gmail.com>
And add a few tests that use freeze to the freeze group
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
tests/xfs/119 | 1 +
tests/xfs/318 | 3 ++-
tests/xfs/325 | 3 ++-
tests/xfs/422 | 3 ++-
tests/xfs/438 | 2 +-
tests/xfs/517 | 1 +
6 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/tests/xfs/119 b/tests/xfs/119
index a1180371..b6f96601 100755
--- a/tests/xfs/119
+++ b/tests/xfs/119
@@ -20,6 +20,7 @@ _begin_fstest log v2log auto freeze
_supported_fs xfs
_require_scratch
+_require_freeze
# this may hang
sync
diff --git a/tests/xfs/318 b/tests/xfs/318
index 38c7aa60..be93f9ab 100755
--- a/tests/xfs/318
+++ b/tests/xfs/318
@@ -7,7 +7,7 @@
# Simulate free extent errors with a file write and a file remove.
#
. ./common/preamble
-_begin_fstest auto quick rw
+_begin_fstest auto quick rw freeze
# Override the default cleanup function.
_cleanup()
@@ -26,6 +26,7 @@ _supported_fs xfs
_require_scratch
_require_error_injection
_require_xfs_io_error_injection "rmap_finish_one"
+_require_freeze
blksz=65536
blks=64
diff --git a/tests/xfs/325 b/tests/xfs/325
index 5b26b2b3..c6861fbc 100755
--- a/tests/xfs/325
+++ b/tests/xfs/325
@@ -8,7 +8,7 @@
# Inject an error during extent freeing to test log recovery.
#
. ./common/preamble
-_begin_fstest auto quick clone
+_begin_fstest auto quick clone freeze
# Override the default cleanup function.
_cleanup()
@@ -29,6 +29,7 @@ _require_cp_reflink
_require_scratch_reflink
_require_error_injection
_require_xfs_io_error_injection "free_extent"
+_require_freeze
blksz=65536
blks=30
diff --git a/tests/xfs/422 b/tests/xfs/422
index 175253aa..a83a66df 100755
--- a/tests/xfs/422
+++ b/tests/xfs/422
@@ -9,7 +9,7 @@
# activity, so we can't have userspace wandering in and thawing it.
#
. ./common/preamble
-_begin_fstest dangerous_scrub dangerous_online_repair
+_begin_fstest dangerous_scrub dangerous_online_repair freeze
_register_cleanup "_cleanup" BUS
@@ -24,6 +24,7 @@ _require_xfs_scratch_rmapbt
_require_xfs_io_command "scrub"
_require_xfs_io_error_injection "force_repair"
_require_command "$KILLALL_PROG" killall
+_require_freeze
echo "Format and populate"
_scratch_mkfs > "$seqres.full" 2>&1
diff --git a/tests/xfs/438 b/tests/xfs/438
index c3008b1c..cfe75bd8 100755
--- a/tests/xfs/438
+++ b/tests/xfs/438
@@ -21,7 +21,7 @@
# Fixed by upstream commit 373b058 ("xfs: Properly retry failed dquot
# items in case of error during buffer writeback")
. ./common/preamble
-_begin_fstest auto quick quota
+_begin_fstest auto quick quota freeze
# Override the default cleanup function.
_cleanup()
diff --git a/tests/xfs/517 b/tests/xfs/517
index 88c4f43b..f7f9a8a2 100755
--- a/tests/xfs/517
+++ b/tests/xfs/517
@@ -29,6 +29,7 @@ _supported_fs xfs
_require_xfs_scratch_rmapbt
_require_xfs_io_command "fsmap"
_require_command "$KILLALL_PROG" killall
+_require_freeze
echo "Format and populate"
_scratch_mkfs > "$seqres.full" 2>&1
--
2.25.1
next prev parent reply other threads:[~2022-06-21 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 17:37 [PATCH v2 0/3] aborted fstests may leave frozen fs behind Amir Goldstein
2022-06-21 17:37 ` Amir Goldstein [this message]
2022-06-24 15:26 ` [PATCH v2 1/3] fstests: add missing _require_freeze() to tests Zorro Lang
2022-06-21 17:37 ` [PATCH v2 2/3] fstests: unfreeze fs on cleanup routines Amir Goldstein
2022-06-24 16:06 ` Zorro Lang
2022-06-21 17:37 ` [PATCH v2 3/3] xfs/{422,517}: kill background jobs on test termination Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621173729.2135249-2-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox