From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH 2/5] ext4/044: skip test if the file system does not have a journal
Date: Fri, 24 Jun 2022 23:07:15 -0400 [thread overview]
Message-ID: <20220625030718.1215980-3-tytso@mit.edu> (raw)
In-Reply-To: <20220625030718.1215980-1-tytso@mit.edu>
This test mounts the file system using "mount -t ext3"; if the file
system config creates the file system without the jbd2 journal, the
"mount -t ext3" will fail. So skip this test in that case.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
tests/ext4/044 | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/ext4/044 b/tests/ext4/044
index 46e44053..fd27ae2d 100755
--- a/tests/ext4/044
+++ b/tests/ext4/044
@@ -16,11 +16,17 @@ _begin_fstest auto quick
_supported_fs ext4
_require_scratch
_require_test_program "t_get_file_time"
+_require_dumpe2fs
echo "Silence is golden"
echo "Test timestamps with 256 inode size one device $SCRATCH_DEV" >$seqres.full
_scratch_mkfs -t ext3 -I 256 >> $seqres.full 2>&1
+
+$DUMPE2FS_PROG -h $SCRATCH_DEV 2>> $seqres.full | grep '^Filesystem features' | grep -q has_journal
+if [ $? -ne 0 ]; then
+ _notrun "ext4 file system formatted without a journal"
+fi
_scratch_mount
# Create file
--
2.31.0
next prev parent reply other threads:[~2022-06-25 3:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 3:07 [PATCH 0/5] Misceillaneous ext4 test fix ups Theodore Ts'o
2022-06-25 3:07 ` [PATCH 1/5] ext4/050: support indirect as well as extent mapped journals Theodore Ts'o
2022-06-28 4:24 ` Zorro Lang
2022-06-25 3:07 ` Theodore Ts'o [this message]
2022-06-28 4:28 ` [PATCH 2/5] ext4/044: skip test if the file system does not have a journal Zorro Lang
2022-06-28 4:32 ` Zorro Lang
2022-06-28 18:20 ` Theodore Ts'o
2022-06-25 3:07 ` [PATCH 3/5] ext4/045: clean up unnecessary arguments to _require_e2fsprogs Theodore Ts'o
2022-06-28 4:37 ` Zorro Lang
2022-06-28 18:21 ` Theodore Ts'o
2022-06-25 3:07 ` [PATCH 4/5] ext4/054: skip test if the dax mount option is enabled Theodore Ts'o
2022-06-28 4:39 ` Zorro Lang
2022-06-25 3:07 ` [PATCH 5/5] ext4/055: skip test if dax mount option is used Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220625030718.1215980-3-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox