From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A795AC433EF for ; Wed, 29 Jun 2022 04:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231326AbiF2EWL (ORCPT ); Wed, 29 Jun 2022 00:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbiF2EWK (ORCPT ); Wed, 29 Jun 2022 00:22:10 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 117DA20BE8; Tue, 28 Jun 2022 21:22:10 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 2B0EA10E7D07; Wed, 29 Jun 2022 14:22:09 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1o6PDL-00CKqA-J2; Wed, 29 Jun 2022 14:22:07 +1000 Date: Wed, 29 Jun 2022 14:22:07 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: guaneryu@gmail.com, zlang@redhat.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Subject: Re: [PATCH 5/9] check: document mkfs.xfs reliance on fstests exports Message-ID: <20220629042207.GR1098723@dread.disaster.area> References: <165644767753.1045534.18231838177395571946.stgit@magnolia> <165644770574.1045534.3646229611370914936.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165644770574.1045534.3646229611370914936.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=OJNEYQWB c=1 sm=1 tr=0 ts=62bbd371 a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=JPEYwPQDsx4A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=Egxrm0js6VwTifgDdhMA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Tue, Jun 28, 2022 at 01:21:45PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > There are a number of fstests that employ special (and now unsupported) > XFS filesystem configurations to perform testing in a controlled > environment. The presence of the QA_CHECK_FS and MSGVERB variables are > used by mkfs.xfs to detect that it's running inside fstests, which > enables the unsupported configurations. Nobody else should be using > filesystems with tiny logs, non-redundant superblocks, or smaller than > the (new) minimum supported size. > > Signed-off-by: Darrick J. Wong looks fine, and answers a question I had looking at some of the mkfs modifications you've proposed. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com