From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH 3/4] dmflakey: don't run dmflakey tests with an external log device
Date: Wed, 20 Jul 2022 12:43:55 -0400 [thread overview]
Message-ID: <20220720164356.4078789-4-tytso@mit.edu> (raw)
In-Reply-To: <20220720164356.4078789-1-tytso@mit.edu>
dmflakey works by dropping all writes before unmounting to simulate a
crash/power loss. This doesn't work if there is an external log
device, since we only drop writes to the primary block device, and not
the external log device. Fixing this for real would require somehow
arranging to atomically loading a new dmflakey table for two block
devices at the same time, so for now, just skip tests using dmflakey
if the external log device is enabled.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
common/dmflakey | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/common/dmflakey b/common/dmflakey
index 52da3b10..c2be78e9 100644
--- a/common/dmflakey
+++ b/common/dmflakey
@@ -12,6 +12,10 @@ _init_flakey()
{
# Scratch device
local BLK_DEV_SIZE=`blockdev --getsz $SCRATCH_DEV`
+
+ if test "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ; then
+ _notrun "dmflakey tests don't work with an external log device"
+ fi
FLAKEY_DEV=/dev/mapper/flakey-test
FLAKEY_TABLE="0 $BLK_DEV_SIZE flakey $SCRATCH_DEV 0 180 0"
FLAKEY_TABLE_DROP="0 $BLK_DEV_SIZE flakey $SCRATCH_DEV 0 0 180 1 drop_writes"
--
2.31.0
next prev parent reply other threads:[~2022-07-20 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 16:43 [PATCH 0/4] fstests: more random fixes from Ted Theodore Ts'o
2022-07-20 16:43 ` [PATCH 1/4] report: add support for the xunit-quiet format Theodore Ts'o
2022-07-20 18:35 ` Darrick J. Wong
2022-07-20 16:43 ` [PATCH 2/4] generic/556: add a check to make sure ext4 supports encrypted casefolding Theodore Ts'o
2022-07-21 2:40 ` Eric Biggers
2022-07-20 16:43 ` Theodore Ts'o [this message]
2022-07-20 17:35 ` [PATCH 3/4] dmflakey: don't run dmflakey tests with an external log device Darrick J. Wong
2022-07-20 16:43 ` [PATCH 4/4] generic/475: skip test when using " Theodore Ts'o
2022-07-20 18:29 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720164356.4078789-4-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox