From: Christian Brauner <brauner@kernel.org>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org, sforshee@digitalocean.com,
amir73il@gmail.com, hch@lst.de, cyphar@cyphar.com
Subject: Re: [PATCH v4 0/2] group ownership changing test
Date: Tue, 20 Sep 2022 16:50:06 +0200 [thread overview]
Message-ID: <20220920145006.bsrinbmqwrk5kl7w@wittgenstein> (raw)
In-Reply-To: <20220920115035.2472076-1-zlang@kernel.org>
On Tue, Sep 20, 2022 at 07:50:33PM +0800, Zorro Lang wrote:
> Hi Christian,
>
> It's been 3 month past, since your patch [1] was reviewed last time. I'm still
> waititng for this test coverage for fs. According to the review points last
> time, I split your v3 patch [1] to 2 separated cases, one basic testing for
> covering that fix, one extend testing for overlay part.
>
> I only did below changes (compare with v3):
> 1) Split one case to two cases.
> 2) Move "_supports_filetype" line under the _scratch_mount.
>
> I still keep the patch Author as you, and signed-off-by you, due to I just
> hope to bring this discussion back, and push the proceeding of this patch
> be merged.
>
> (CC the old cc list to get more review)
>
> Thanks,
> Zorro
>
> [1]
> https://lore.kernel.org/fstests/20220615092826.2333847-1-brauner@kernel.org/
Zorro,
Thank you for picking this patchset up! I just didn't have the time.
I've applied it, reviewed, and tested it:
Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
Tested-by: Christian Brauner (Microsoft) <brauner@kernel.org>
We really need this regression test!
Christian
next prev parent reply other threads:[~2022-09-20 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 11:50 [PATCH v4 0/2] group ownership changing test Zorro Lang
2022-09-20 11:50 ` [PATCH v4 1/2] generic: basic " Zorro Lang
2022-09-20 11:50 ` [PATCH v4 2/2] generic: overlay " Zorro Lang
2022-09-20 14:50 ` Christian Brauner [this message]
2022-09-20 15:11 ` [PATCH v4 0/2] " Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920145006.bsrinbmqwrk5kl7w@wittgenstein \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=cyphar@cyphar.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=sforshee@digitalocean.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox