From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC259C4332F for ; Wed, 14 Dec 2022 11:32:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238264AbiLNLcb (ORCPT ); Wed, 14 Dec 2022 06:32:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238236AbiLNLc3 (ORCPT ); Wed, 14 Dec 2022 06:32:29 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B09F11816; Wed, 14 Dec 2022 03:32:28 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E9A2F22289; Wed, 14 Dec 2022 11:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1671017546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7zeLFl9gcdPCJ0Huj5C5N8ESv3K7b/0mCljOQLsoUn0=; b=m/Knqkhvcgc6SX39rYPpQMCizGchblCMV4eSn8zqlnY810rEARLSXyhtA1pcMbbEO+SeC8 2aWqyo61LRphCMKTLwnJ1WgSDUybPdZeb/6fnz0NsZJR2d169d8YnTTdiXV1D1IPY+K1OH bNJ/FKn1ETGvjulbIarU2W28EwQCxkg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1671017546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7zeLFl9gcdPCJ0Huj5C5N8ESv3K7b/0mCljOQLsoUn0=; b=Wl6Emedd1tBwUwro9M5vB8YL0w0e2D07zSF3vkxE8saj4G2gQxKO2EJzZLCtJCCvNo2U7f Erpfbotd3jbAHCDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B06FE138F6; Wed, 14 Dec 2022 11:32:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xo6tKUq0mWPNRAAAMHmgww (envelope-from ); Wed, 14 Dec 2022 11:32:26 +0000 Date: Wed, 14 Dec 2022 12:33:16 +0100 From: David Disseldorp To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH] check: call _check_dmesg even if the test case failed Message-ID: <20221214123316.4c26cc69@echidna.fritz.box> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org Hi Qu, On Wed, 14 Dec 2022 08:08:31 +0800, Qu Wenruo wrote: ... > index d2e5129620bd..487da43537ad 100755 > --- a/check > +++ b/check > @@ -950,6 +950,9 @@ function run_section() > _scratch_unmount 2> /dev/null > rm -f ${RESULT_DIR}/require_test* > rm -f ${RESULT_DIR}/require_scratch* > + # Even we failed, there may be something interesting in > + # dmesg which can help debugging. Nit: "Even though we ...", although the comment is probably unnecessary. > + _check_dmesg > tc_status="fail" > else > # The test apparently passed, so check for corruption Makes sense. Reviewed-by: David Disseldorp