FS/XFS testing framework
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/1] xfs/122: fix EFI/EFD log format structure size after flex array conversion
Date: Thu, 15 Dec 2022 02:40:47 +0800	[thread overview]
Message-ID: <20221214184047.k3iaxggotcli4423@zlang-mailbox> (raw)
In-Reply-To: <167096074260.1750519.311637326793150150.stgit@magnolia>

On Tue, Dec 13, 2022 at 11:45:42AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Adjust this test since made EFI/EFD log item format structs proper flex
> arrays instead of array[1].
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---

So we let this case fail on all older system/kernel? Is the kernel patch
recommended to be merged on downstream kernel?

Thanks,
Zorro

>  tests/xfs/122.out |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> 
> diff --git a/tests/xfs/122.out b/tests/xfs/122.out
> index a56cbee84f..95e53c5081 100644
> --- a/tests/xfs/122.out
> +++ b/tests/xfs/122.out
> @@ -161,10 +161,10 @@ sizeof(xfs_disk_dquot_t) = 104
>  sizeof(xfs_dq_logformat_t) = 24
>  sizeof(xfs_dqblk_t) = 136
>  sizeof(xfs_dsb_t) = 264
> -sizeof(xfs_efd_log_format_32_t) = 28
> -sizeof(xfs_efd_log_format_64_t) = 32
> -sizeof(xfs_efi_log_format_32_t) = 28
> -sizeof(xfs_efi_log_format_64_t) = 32
> +sizeof(xfs_efd_log_format_32_t) = 16
> +sizeof(xfs_efd_log_format_64_t) = 16
> +sizeof(xfs_efi_log_format_32_t) = 16
> +sizeof(xfs_efi_log_format_64_t) = 16
>  sizeof(xfs_error_injection_t) = 8
>  sizeof(xfs_exntfmt_t) = 4
>  sizeof(xfs_exntst_t) = 4
> 


  reply	other threads:[~2022-12-14 18:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 19:45 [PATCHSET 0/1] fstests: fix tests for kernel 6.1 Darrick J. Wong
2022-12-13 19:45 ` [PATCH 1/1] xfs/122: fix EFI/EFD log format structure size after flex array conversion Darrick J. Wong
2022-12-14 18:40   ` Zorro Lang [this message]
2022-12-17  8:14     ` Darrick J. Wong
2022-12-17 10:00       ` Zorro Lang
2022-12-19 17:14         ` Darrick J. Wong
2022-12-19 19:01           ` Zorro Lang
  -- strict thread matches above, loose matches on Subject: below --
2022-12-21  0:21 [PATCHSET 0/1] fstests: fix tests for kernel 6.1 Darrick J. Wong
2022-12-21  0:21 ` [PATCH 1/1] xfs/122: fix EFI/EFD log format structure size after flex array conversion Darrick J. Wong
2022-12-22  7:19   ` Zorro Lang
2022-12-22 18:38     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221214184047.k3iaxggotcli4423@zlang-mailbox \
    --to=zlang@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox