From: David Disseldorp <ddiss@suse.de>
To: Leah Rumancik <leah.rumancik@gmail.com>
Cc: fstests@vger.kernel.org, djwong@kernel.org
Subject: Re: [PATCH] check: wipe tmp.arglist
Date: Thu, 15 Dec 2022 12:36:15 +0100 [thread overview]
Message-ID: <20221215123615.657bcfad@echidna.fritz.box> (raw)
In-Reply-To: <20221214215926.908628-1-leah.rumancik@gmail.com>
Hi Leah,
On Wed, 14 Dec 2022 13:59:26 -0800, Leah Rumancik wrote:
> Make sure tmp.arglist is wiped before each run to avoid
> accidentally rerunning tests.
>
> Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
> ---
> check | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/check b/check
> index d2e51296..81a30928 100755
> --- a/check
> +++ b/check
> @@ -46,7 +46,7 @@ export DIFF_LENGTH=${DIFF_LENGTH:=10}
> # by default don't output timestamps
> timestamp=${TIMESTAMP:=false}
>
> -rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
> +rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.* $tmp.arglist
>
> SRC_GROUPS="generic shared"
> export SRC_DIR="tests"
I can't quite see how "accidental rerun" can happen, given that
_summary()/_wrapup() should remove any $tmp.arglist on completion,
and a PID collision for $tmp would also be needed. That said, it still
probably makes sense to be consistent with the other files here, so:
Reviewed-by: David Disseldorp <ddiss@suse.de>
next prev parent reply other threads:[~2022-12-15 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 21:59 [PATCH] check: wipe tmp.arglist Leah Rumancik
2022-12-15 11:36 ` David Disseldorp [this message]
2022-12-15 16:10 ` Darrick J. Wong
2022-12-19 19:03 ` Leah Rumancik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215123615.657bcfad@echidna.fritz.box \
--to=ddiss@suse.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=leah.rumancik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox