From: Jan Kara <jack@suse.cz>
To: <fstests@vger.kernel.org>
Cc: Zorro Lang <zlang@redhat.com>, Jan Kara <jack@suse.cz>
Subject: [PATCH v3 3/3] common: Improve blocksize support for udf
Date: Tue, 31 Jan 2023 13:39:59 +0100 [thread overview]
Message-ID: <20230131124005.14207-3-jack@suse.cz> (raw)
In-Reply-To: <20230131123809.28200-1-jack@suse.cz>
Add better support for blocksize selection in _scratch_mkfs_sized
(accept another variant of mkfs options, select correct default block
size if not specified). Also add blocksize selection support to
_scratch_mkfs_blocksized.
For _check_udf_filesystem to keep working when blocksize is not
specified in MKFS_OPTIONS, add detection of blocksize from a mounted
filesystem.
Signed-off-by: Jan Kara <jack@suse.cz>
---
common/rc | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/common/rc b/common/rc
index 7f80afe7aeec..e49918c9deab 100644
--- a/common/rc
+++ b/common/rc
@@ -922,9 +922,15 @@ _scratch_mkfs_sized()
btrfs)
def_blksz=`echo $MKFS_OPTIONS | sed -rn 's/.*-s ?+([0-9]+).*/\1/p'`
;;
- ext2|ext3|ext4|ext4dev|udf|reiser4|ocfs2|reiserfs)
+ ext2|ext3|ext4|ext4dev|reiser4|ocfs2|reiserfs)
def_blksz=`echo $MKFS_OPTIONS | sed -rn 's/.*-b ?+([0-9]+).*/\1/p'`
;;
+ udf)
+ def_blksz=`echo $MKFS_OPTIONS | sed -rn 's/.*(-b|--blocksize)[ =]?+([0-9]+).*/\2/p'`
+ if [ -z "$def_blksz" ]; then
+ def_blksz=512
+ fi
+ ;;
jfs)
def_blksz=4096
;;
@@ -1116,6 +1122,9 @@ _scratch_mkfs_blocksized()
${MKFS_PROG} -t $FSTYP $MKFS_OPTIONS --block_size=$blocksize \
$SCRATCH_DEV
;;
+ udf)
+ _scratch_mkfs -b $blocksize
+ ;;
*)
_notrun "Filesystem $FSTYP not supported in _scratch_mkfs_blocksized"
;;
@@ -3074,17 +3083,18 @@ _check_udf_filesystem()
return
fi
+ local device=$1
+ local blksz=`echo $MKFS_OPTIONS | sed -rn 's/.*(-b|--blocksize)[ =]?+([0-9]+).*/\2/p'`
+ if [ -z "$blksz" ]; then
+ blksz=512
+ fi
# Is the filesystem mounted?
local type=`_fs_type $device`
if [ "$type" = "$FSTYP" ]; then
+ blksz=`blockdev --getbsz $device`
local mountpoint=`_umount_or_remount_ro $device`
fi
- local device=$1
- local blksz=`echo $MKFS_OPTIONS | sed -rn 's/.*(-b|--blocksize)[ =]?+([0-9]+).*/\2/p'`
- if [ -z "$blksz" ]; then
- blksz=512
- fi
local opt_arg="-ecclength 1 -blocksize $blksz"
if [ $# -eq 2 ]; then
opt_arg+=" -lastvalidblock $(( $2 - 1 ))"
--
2.35.3
next prev parent reply other threads:[~2023-01-31 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 12:39 [PATCH v3 0/3] fstests: Fix checking of UDF filesystems Jan Kara
2023-01-31 12:39 ` [PATCH v3 1/3] common: Provide blocksize and ecclength to udf fsck Jan Kara
2023-01-31 12:39 ` [PATCH v3 2/3] common: Unmount udf filesystem prior checking Jan Kara
2023-02-06 11:00 ` Zorro Lang
2023-01-31 12:39 ` Jan Kara [this message]
2023-02-06 11:12 ` [PATCH v3 3/3] common: Improve blocksize support for udf Zorro Lang
2023-02-07 12:28 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131124005.14207-3-jack@suse.cz \
--to=jack@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox