From: Christian Brauner <brauner@kernel.org>
To: Gabriel Niebler <gniebler@suse.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common: Do not chown ro mountpoint when creating idmapped mount
Date: Mon, 6 Feb 2023 15:51:04 +0100 [thread overview]
Message-ID: <20230206145104.hxuvcsxvml7v36ms@wittgenstein> (raw)
In-Reply-To: <20230203143545.23689-1-gniebler@suse.com>
On Fri, Feb 03, 2023 at 03:35:45PM +0100, Gabriel Niebler wrote:
> The function _idmapped_mount tries to change the ownership of the mountpoint
> for which it aims to create an idmapped mount, to ensure that the mapped UID
> and GID can actually create objects within it. Some tests set up a read-only
> mount, however, which lets the chown call fail. This patch fixes the
> function to check whether the mount is read-only and skip the chown, if so.
>
> Signed-off-by: Gabriel Niebler <gniebler@suse.com>
> ---
Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
Thanks for fixing this!
prev parent reply other threads:[~2023-02-06 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 14:35 [PATCH] common: Do not chown ro mountpoint when creating idmapped mount Gabriel Niebler
2023-02-03 17:54 ` [PATCH] common: Chown mount even if already idmapped to account for remounts Gabriel Niebler
2023-02-06 14:53 ` Christian Brauner
2023-02-06 14:51 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206145104.hxuvcsxvml7v36ms@wittgenstein \
--to=brauner@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=gniebler@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox