From: David Disseldorp <ddiss@suse.de>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Zorro Lang <zlang@redhat.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>
Subject: Re: [PATCH v2] common/rc: don't clear superblock for zoned scratch pools
Date: Mon, 27 Feb 2023 11:14:41 +0100 [thread overview]
Message-ID: <20230227111441.5eac2e29@echidna.fritz.box> (raw)
In-Reply-To: <0df9a175-b18d-4706-ae69-ed019b326924@wdc.com>
On Mon, 27 Feb 2023 09:31:53 +0000, Johannes Thumshirn wrote:
> On 27.02.23 10:22, David Disseldorp wrote:
> >> - # to help better debug when something fails, we remove
> >> - # traces of previous btrfs FS on the dev.
> >> - dd if=/dev/zero of=$i bs=4096 count=100 > /dev/null 2>&1
> >> + # To help better debug when something fails, we remove
> >> + # traces of previous btrfs FS on the dev. For zoned devices we
> >> + # can't use dd as it'll lead to unaligned writes so simply
> >> + # reset the first two zones.
> >> + if [ "`_zone_type "$i"`" = "none" ]; then
> >> + dd if=/dev/zero of=$i bs=4096 count=100 > /dev/null 2>&1
> >> + else
> >> + blkzone reset -c 2 $i
> >> + fi
> >
> > IIUC, any output from blkzone reset will cause test failures - is that
> > an intention here, or should output go to /dev/null like dd?
> >
> > Looks fine otherwise.
>
> If all is well, blkzone reset won't have any output. So I guess we're fine.
Thanks for the confirmation. In that case:
Reviewed-by: David Disseldorp <ddiss@suse.de>
next prev parent reply other threads:[~2023-02-27 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 8:27 [PATCH v2] common/rc: don't clear superblock for zoned scratch pools Johannes Thumshirn
2023-02-27 9:23 ` David Disseldorp
2023-02-27 9:31 ` Johannes Thumshirn
2023-02-27 10:14 ` David Disseldorp [this message]
2023-03-02 7:17 ` Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227111441.5eac2e29@echidna.fritz.box \
--to=ddiss@suse.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox