From: Christian Brauner <brauner@kernel.org>
To: Rodrigo Campos <rodrigo@sdfg.com.ar>
Cc: fstests@vger.kernel.org, Giuseppe Scrivano <gscrivan@redhat.com>
Subject: Re: [PATCH 11/11] vfs: Use tabs to indent, not spaces
Date: Tue, 7 Mar 2023 17:55:08 +0100 [thread overview]
Message-ID: <20230307165508.77ptsmv2zdotw6xg@wittgenstein> (raw)
In-Reply-To: <20230307114507.332309-12-rodrigo@sdfg.com.ar>
On Tue, Mar 07, 2023 at 12:45:07PM +0100, Rodrigo Campos wrote:
> Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
> ---
I think I explicitly used spaces but I don't know why anymore tbh. So
I'll live that to Zorro whether he wants to take this patch or not. I
have no strong opinion. :)
> src/vfs/vfstest.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git src/vfs/vfstest.c src/vfs/vfstest.c
> index 3d75b1e3..dea344cc 100644
> --- src/vfs/vfstest.c
> +++ src/vfs/vfstest.c
> @@ -107,7 +107,7 @@ static int hardlink_crossing_mounts(const struct vfstest_info *info)
> int fret = -1;
> int file1_fd = -EBADF, open_tree_fd = -EBADF;
>
> - if (chown_r(info->t_mnt_fd, T_DIR1, 10000, 10000)) {
> + if (chown_r(info->t_mnt_fd, T_DIR1, 10000, 10000)) {
> log_stderr("failure: chown_r");
> goto out;
> }
> @@ -2307,22 +2307,22 @@ static void usage(void)
> fprintf(stderr, " Run idmapped mount tests\n\n");
>
> fprintf(stderr, "Arguments:\n");
> - fprintf(stderr, "--device Device used in the tests\n");
> - fprintf(stderr, "--fstype Filesystem type used in the tests\n");
> - fprintf(stderr, "--help Print help\n");
> - fprintf(stderr, "--mountpoint Mountpoint of device\n");
> - fprintf(stderr, "--idmapped-mounts-supported Test whether idmapped mounts are supported on this filesystem\n");
> - fprintf(stderr, "--scratch-mountpoint Mountpoint of scratch device used in the tests\n");
> - fprintf(stderr, "--scratch-device Scratch device used in the tests\n");
> - fprintf(stderr, "--test-core Run core idmapped mount testsuite\n");
> - fprintf(stderr, "--test-fscaps-regression Run fscap regression tests\n");
> - fprintf(stderr, "--test-nested-userns Run nested userns idmapped mount testsuite\n");
> - fprintf(stderr, "--test-btrfs Run btrfs specific idmapped mount testsuite\n");
> - fprintf(stderr, "--test-tmpfs Run tmpfs specific idmapped mount testsuite\n");
> + fprintf(stderr, "--device Device used in the tests\n");
> + fprintf(stderr, "--fstype Filesystem type used in the tests\n");
> + fprintf(stderr, "--help Print help\n");
> + fprintf(stderr, "--mountpoint Mountpoint of device\n");
> + fprintf(stderr, "--idmapped-mounts-supported Test whether idmapped mounts are supported on this filesystem\n");
> + fprintf(stderr, "--scratch-mountpoint Mountpoint of scratch device used in the tests\n");
> + fprintf(stderr, "--scratch-device Scratch device used in the tests\n");
> + fprintf(stderr, "--test-core Run core idmapped mount testsuite\n");
> + fprintf(stderr, "--test-fscaps-regression Run fscap regression tests\n");
> + fprintf(stderr, "--test-nested-userns Run nested userns idmapped mount testsuite\n");
> + fprintf(stderr, "--test-btrfs Run btrfs specific idmapped mount testsuite\n");
> + fprintf(stderr, "--test-tmpfs Run tmpfs specific idmapped mount testsuite\n");
> fprintf(stderr, "--test-setattr-fix-968219708108 Run setattr regression tests\n");
> fprintf(stderr, "--test-setxattr-fix-705191b03d50 Run setxattr regression tests\n");
> - fprintf(stderr, "--test-setgid-create-umask Run setgid with umask tests\n");
> - fprintf(stderr, "--test-setgid-create-acl Run setgid with acl tests\n");
> + fprintf(stderr, "--test-setgid-create-umask Run setgid with umask tests\n");
> + fprintf(stderr, "--test-setgid-create-acl Run setgid with acl tests\n");
>
> _exit(EXIT_SUCCESS);
> }
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-03-07 17:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 11:44 [PATCH 00/11] Tests for idmapped tmpfs Rodrigo Campos
2023-03-07 11:44 ` [PATCH 01/11] vfs: Don't open-code safe_close() Rodrigo Campos
2023-03-07 16:42 ` Christian Brauner
2023-03-07 11:44 ` [PATCH 02/11] vfs: Fix documentation typo Rodrigo Campos
2023-03-07 16:43 ` Christian Brauner
2023-03-07 11:44 ` [PATCH 03/11] vfs: Fix race condition on get_userns_fd() Rodrigo Campos
2023-03-07 16:46 ` Christian Brauner
2023-03-07 17:32 ` Rodrigo Campos
2023-03-07 11:45 ` [PATCH 04/11] vfs: Make switch_userns set PR_SET_DUMPABLE Rodrigo Campos
2023-03-07 16:47 ` Christian Brauner
2023-03-07 11:45 ` [PATCH 05/11] vfs: Specify wether a test is run inside a userns or not Rodrigo Campos
2023-03-07 11:45 ` [PATCH 06/11] vfs: Prepare tests in &s_idmapped_mounts to be reused inside a userns Rodrigo Campos
2023-03-07 16:50 ` Christian Brauner
2023-03-07 23:34 ` Rodrigo Campos
2023-03-13 10:37 ` Christian Brauner
2023-03-07 11:45 ` [PATCH 07/11] vfs: Make idmapped core tests public Rodrigo Campos
2023-03-07 16:51 ` Christian Brauner
2023-03-07 11:45 ` [PATCH 08/11] vfs: Export test_setup() and test_cleanup() Rodrigo Campos
2023-03-07 16:51 ` Christian Brauner
2023-03-07 17:11 ` Rodrigo Campos
2023-03-07 11:45 ` [PATCH 09/11] vfs: Add DIR0 constant Rodrigo Campos
2023-03-07 16:53 ` Christian Brauner
2023-03-07 17:33 ` Rodrigo Campos
2023-03-07 11:45 ` [PATCH 10/11] vfs: Add tmpfs tests for idmap mounts Rodrigo Campos
2023-03-07 11:45 ` [PATCH 11/11] vfs: Use tabs to indent, not spaces Rodrigo Campos
2023-03-07 16:55 ` Christian Brauner [this message]
2023-03-07 17:10 ` Rodrigo Campos
2023-03-08 17:27 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307165508.77ptsmv2zdotw6xg@wittgenstein \
--to=brauner@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=gscrivan@redhat.com \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).