From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>, "Darrick J . Wong" <djwong@kernel.org>
Subject: [PATCH -v2 2/2] report: remove xmlns specifier
Date: Fri, 7 Jul 2023 15:27:04 -0400 [thread overview]
Message-ID: <20230707192704.2654426-2-tytso@mit.edu> (raw)
In-Reply-To: <20230707192704.2654426-1-tytso@mit.edu>
By specifying "xmlns=https://git.kernel.org/.../xfstests-dev.git",
this causes XML complaint parsers, such as the one used by the python
junitparser library, to put all of the XML elements into a namespace,
which then causes junitparser to toss its cookies.
This can be worked-around in a test runner script via:
sed -i.orig -e 's/xmlns=\".*\"//' "$RESULT_BASE/result.xml"
but it's better not to include the xmlns line at all in the first
place, since this may cause other users of fstests who are using
the Python junitparser library a lot of headaches.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---
changes from v1:
* minor updates to the commit description
common/report | 1 -
1 file changed, 1 deletion(-)
diff --git a/common/report b/common/report
index 3c58f0e3c..0e91e481f 100644
--- a/common/report
+++ b/common/report
@@ -128,7 +128,6 @@ _xunit_make_section_report()
local fstests_ns="https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git"
cat >> "$tmp_fn" << ENDL
<testsuite
- xmlns="$fstests_ns"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="$fstests_ns $fstests_ns/tree/doc/xunit.xsd"
--
2.31.0
prev parent reply other threads:[~2023-07-07 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 19:27 [PATCH -v2 1/2] report: safely update the result.xml file Theodore Ts'o
2023-07-07 19:27 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707192704.2654426-2-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox