From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH] generic: add a test for device removal with dirty data
Date: Mon, 24 Jul 2023 15:32:36 +0200 [thread overview]
Message-ID: <20230724133236.GB20744@lst.de> (raw)
In-Reply-To: <20230723045017.1706370-1-zlang@kernel.org>
On Sun, Jul 23, 2023 at 12:50:17PM +0800, Zorro Lang wrote:
> I'd like to help this patchset to catch this or next fstests release. So I
> changed this patch a bit, if you feel good, I'll merge this patch as below.
> (Same to the 2nd patch).
I've actually got a few other changes locally nad plant to send it out.
> Change logs:
> 1) Replace SCRATCH_DEV with TEST_DEV, replace SCRATCH_MNT with SCSI_DEBUG_MNT
> which is a directory in TEST_DIR, due to we don't call _require_scratch
> in this case.
The SCSI_DEBUG_MNT change is fine. The SCRATCH_DEV stuff I think we don't
need at all, after all the sector size doesn't really matter for this
test, so I've just dropped it.
> 2) Call _fail if _mkfs_dev or _mount fails
Shouldn't the mkfs side also use run_check ?
Btw, your cleanups should also go into generic/108 from where I took
the scsi_debug boilerplate.
I'll resend later today, also incorporating your changes.
next prev parent reply other threads:[~2023-07-24 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 10:09 add device removal test v2 Christoph Hellwig
2023-07-11 10:09 ` [PATCH 1/2] generic: add a test for device removal with dirty data Christoph Hellwig
2023-07-18 10:34 ` Zorro Lang
2023-07-23 4:50 ` [PATCH] " Zorro Lang
2023-07-24 13:32 ` Christoph Hellwig [this message]
2023-07-11 10:09 ` [PATCH 2/2] generic: add a test for device removal without " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724133236.GB20744@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox