FS/XFS testing framework
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: fstests@vger.kernel.org
Cc: linux-nfs@vger.kernel.org, Zorro Lang <zlang@redhat.com>,
	Jeff Layton <jlayton@kernel.org>
Subject: [PATCH fstests v2 3/3] generic/187: don't run this test on NFS
Date: Fri, 01 Sep 2023 13:39:57 -0400	[thread overview]
Message-ID: <20230901-nfs-skip-v2-3-9eccd59bc524@kernel.org> (raw)
In-Reply-To: <20230901-nfs-skip-v2-0-9eccd59bc524@kernel.org>

This test is unreliable on NFS. It fails consistently when run vs. a
server exporting btrfs, but passes when the server exports xfs. Since we
don't have any sort of attribute that we can require to test this, just
skip this one on NFS.

Also, subsume the check for btrfs into the _supported_fs check, and add
a comment for it.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 tests/generic/187 | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/generic/187 b/tests/generic/187
index 0653b92f12f4..1b3509424462 100755
--- a/tests/generic/187
+++ b/tests/generic/187
@@ -29,13 +29,17 @@ _cleanup()
 . ./common/reflink
 
 # real QA test starts here
+
+# btrfs can't fragment free space. This test is unreliable on NFS, as it
+# depends on the exported filesystem.
+_supported_fs ^btrfs ^nfs generic
 _require_scratch_reflink
 _require_cp_reflink
 _require_xfs_io_command "falloc"
 _require_xfs_io_command "fpunch"
-test $FSTYP = "btrfs" && _notrun "Can't fragment free space on btrfs."
 _require_odirect
 
+
 _fragment_freesp()
 {
 	file=$1

-- 
2.41.0


      parent reply	other threads:[~2023-09-01 17:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01 17:39 [PATCH fstests v2 0/3] generic: skip a few tests on NFS Jeff Layton
2023-09-01 17:39 ` [PATCH fstests v2 1/3] generic/294: don't run this test " Jeff Layton
2023-09-01 19:19   ` Zorro Lang
2023-09-01 19:37     ` Jeff Layton
2023-09-01 17:39 ` [PATCH fstests v2 2/3] generic/357: " Jeff Layton
2023-09-01 17:39 ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230901-nfs-skip-v2-3-9eccd59bc524@kernel.org \
    --to=jlayton@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox