From: Shiyang Ruan <ruansy.fnst@fujitsu.com>
To: fstests@vger.kernel.org
Cc: ruansy.fnst@fujitsu.com, Zorro Lang <zlang@redhat.com>
Subject: [PATCH v3] tools/mvtest: ensure testcase is executable (755)
Date: Fri, 8 Sep 2023 13:43:35 +0800 [thread overview]
Message-ID: <20230908054335.13625-1-ruansy.fnst@fujitsu.com> (raw)
In-Reply-To: <20230906071349.3643040-1-ruansy.fnst@fujitsu.com>
Some test cases lack executable permission ('x'). Before running each
test case, `./check` checks and grants them 'x' permission. However,
this always leads to a dirty git repo. And the absence of 'x' permission
in test cases is often overlooked during reviews.
Since maintainers use mvtest to assign new case, add this change for
convenience of maintainers.
Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Reviewed-by: Zorro Lang <zlang@redhat.com>
---
tools/mvtest | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/mvtest b/tools/mvtest
index 99b154142..bd4006eb2 100755
--- a/tools/mvtest
+++ b/tools/mvtest
@@ -34,6 +34,8 @@ did="$(basename "${dest}")"
git mv "tests/${src}" "tests/${dest}"
git mv "tests/${src}.out" "tests/${dest}.out"
+# make sure testcase is executable
+chmod 755 "tests/${dest}"
sed -e "s/^# FS[[:space:]]*QA.*Test.*[0-9]\+$/# FS QA Test No. ${did}/g" -i "tests/${dest}"
sed -e "s/^QA output created by ${sid}$/QA output created by ${did}/g" -i "tests/${dest}.out"
sed -e "s/test-${sid}/test-${did}/g" -i "tests/${dest}.out"
--
2.42.0
next prev parent reply other threads:[~2023-09-08 5:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 7:13 [PATCH] tools/mvtest: ensure testcase is executable (755) Shiyang Ruan
2023-09-07 10:25 ` Zorro Lang
2023-09-07 11:35 ` [PATCH v2] tools/mvtests: " Shiyang Ruan
2023-09-08 4:59 ` Zorro Lang
2023-09-07 13:54 ` [PATCH] tools/mvtest: " Zorro Lang
2023-09-08 2:13 ` Shiyang Ruan
2023-09-08 4:02 ` Zorro Lang
2023-09-08 5:43 ` Shiyang Ruan [this message]
2023-09-08 23:36 ` [PATCH v3] " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908054335.13625-1-ruansy.fnst@fujitsu.com \
--to=ruansy.fnst@fujitsu.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox