From: Christian Brauner <brauner@kernel.org>
To: Zorro Lang <zlang@kernel.org>, fstests@vger.kernel.org
Cc: Christian Brauner <brauner@kernel.org>
Subject: [PATCH] common: check user and group existence via id
Date: Mon, 25 Sep 2023 17:22:21 +0200 [thread overview]
Message-ID: <20230925-fstests-check-user-v1-1-09b97257bcdb@kernel.org> (raw)
Newer machines support the creation of users that don't appear in
/etc/passwd but are only available via nss or userdbd. Use the id binary
which is portable and reliable.
With this change I can run xfstests on systems where the users are
created via systemd-userdbd drop-ins. See the documentation in [1] and [2].
Link: [1]: https://man7.org/linux/man-pages/man8/nss-systemd.8.html
Link: [2]: https://man7.org/linux/man-pages/man5/nsswitch.conf.5.html
Signed-off-by: Christian Brauner <brauner@kernel.org>
---
common/rc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/rc b/common/rc
index 76a7e774..44c90f50 100644
--- a/common/rc
+++ b/common/rc
@@ -2450,7 +2450,8 @@ _yp_active()
_cat_passwd()
{
[ $(_yp_active) -eq 0 ] && ypcat passwd
- cat /etc/passwd
+ id -u "$1"
+ [ "$?" == "0" ] && echo "$user:"
}
# cat the group file
@@ -2458,7 +2459,8 @@ _cat_passwd()
_cat_group()
{
[ $(_yp_active) -eq 0 ] && ypcat group
- cat /etc/group
+ id -g "$1"
+ [ "$?" == "0" ] && echo "$group:"
}
# check if a user exists in the system
---
base-commit: 2fddeb5c79ff16bf37e1f1d809bd94b360c27801
change-id: 20230925-fstests-check-user-5487ee9be2ef
next reply other threads:[~2023-09-25 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 15:22 Christian Brauner [this message]
2023-09-26 10:35 ` [PATCH] common: check user and group existence via id Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925-fstests-check-user-v1-1-09b97257bcdb@kernel.org \
--to=brauner@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox