From: "Darrick J. Wong" <djwong@kernel.org>
To: Vyacheslav Yurkov <uvv.mail@gmail.com>
Cc: fstests@vger.kernel.org, Khem Raj <raj.khem@gmail.com>,
Zorro Lang <zlang@redhat.com>
Subject: Re: [PATCH] fsx: Add a return type to aio_rw
Date: Wed, 27 Sep 2023 07:30:53 -0700 [thread overview]
Message-ID: <20230927143053.GC11423@frogsfrogsfrogs> (raw)
In-Reply-To: <20230927131617.100908-1-uvv.mail@gmail.com>
On Wed, Sep 27, 2023 at 03:16:17PM +0200, Vyacheslav Yurkov wrote:
> From: Khem Raj <raj.khem@gmail.com>
>
> Compilers complain about the function prototype otherwise
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: Zorro Lang <zlang@redhat.com>
Whoooops, good catch!
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> ltp/fsx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ltp/fsx.c b/ltp/fsx.c
> index ccb382e7..a30e2a8d 100644
> --- a/ltp/fsx.c
> +++ b/ltp/fsx.c
> @@ -2592,6 +2592,7 @@ out_error:
> return -1;
> }
> #else
> +int
> aio_rw(int rw, int fd, char *buf, unsigned len, unsigned offset)
> {
> fprintf(stderr, "io_rw: need AIO support!\n");
> --
> 2.35.1
>
prev parent reply other threads:[~2023-09-27 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 13:16 [PATCH] fsx: Add a return type to aio_rw Vyacheslav Yurkov
2023-09-27 14:30 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927143053.GC11423@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=raj.khem@gmail.com \
--cc=uvv.mail@gmail.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox