From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs/556: call _require_dm_target later
Date: Mon, 16 Oct 2023 11:37:33 -0700 [thread overview]
Message-ID: <20231016183733.GA11391@frogsfrogsfrogs> (raw)
In-Reply-To: <20231016131103.966920-1-hch@lst.de>
On Mon, Oct 16, 2023 at 03:11:02PM +0200, Christoph Hellwig wrote:
> _require_dm_target tries to use $SCRATCH_DEV, so move it after we've
> established that the configuration has a valid $SCRATCH_DEV.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Oops, thanks for catching that.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> tests/xfs/556 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/556 b/tests/xfs/556
> index 66908a54..061d8d57 100755
> --- a/tests/xfs/556
> +++ b/tests/xfs/556
> @@ -25,10 +25,10 @@ _cleanup()
>
> # real QA test starts here
> _supported_fs xfs
> -_require_dm_target error
> _require_scratch
> _require_scratch_xfs_crc
> _require_scrub
> +_require_dm_target error
>
> filter_scrub_errors() {
> _filter_scratch | sed \
> --
> 2.39.2
>
prev parent reply other threads:[~2023-10-16 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 13:11 [PATCH 1/2] xfs/556: call _require_dm_target later Christoph Hellwig
2023-10-16 13:11 ` [PATCH 2/2] xfs: add missing _require_scratch calls Christoph Hellwig
2023-10-16 18:41 ` Darrick J. Wong
2023-10-17 4:25 ` Christoph Hellwig
2023-10-17 5:37 ` Darrick J. Wong
2023-10-16 18:37 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016183733.GA11391@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox