public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: fstests@vger.kernel.org
Cc: Yongcheng Yang <yoyang@redhat.com>, Jeff Layton <jlayton@kernel.org>
Subject: [PATCH] generic/732: fix mount option munging
Date: Wed, 01 Nov 2023 14:17:13 -0400	[thread overview]
Message-ID: <20231101-master-v1-1-08bbe2f83307@kernel.org> (raw)

With NFS in particular, we are usually testing with some mount options.
Ensure that we preserve those and just add "nosharecache" onto the end
of the string.

Cc: Yongcheng Yang <yoyang@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 tests/generic/732 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/732 b/tests/generic/732
index 785aac58f361..ae49152e42dc 100755
--- a/tests/generic/732
+++ b/tests/generic/732
@@ -40,7 +40,7 @@ mkdir -p $testdir1 $testdir2
 # Don't share the data and attribute caches among mount points for NFS.
 # This caching behavior is necessary to reproduce this issue as we're
 # checking the alignment of each mount point's own unique cache.
-[ "$FSTYP" = "nfs" ] && MOUNT_OPTIONS="-o nosharecache"
+[ "$FSTYP" = "nfs" ] && MOUNT_OPTIONS="$MOUNT_OPTIONS -o nosharecache"
 
 SCRATCH_MNT=$testdir1 _scratch_mount
 SCRATCH_MNT=$testdir2 _scratch_mount

---
base-commit: 59299b65ac8f15935ab45e7920cbfda8a6beffd1
change-id: 20231101-master-328ff30ce66f

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>


             reply	other threads:[~2023-11-01 18:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01 18:17 Jeff Layton [this message]
2023-11-02  8:06 ` [PATCH] generic/732: fix mount option munging Zorro Lang
2023-11-02 18:59   ` Jeff Layton
2023-11-05 18:43     ` Zorro Lang
2023-11-05 20:35       ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231101-master-v1-1-08bbe2f83307@kernel.org \
    --to=jlayton@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=yoyang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox