FS/XFS testing framework
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: fstests@vger.kernel.org
Cc: djwong@kernel.org
Subject: [PATCH] common: fix _require_xfs_io_command for specific swapext versions
Date: Wed,  8 Nov 2023 16:24:01 +0100	[thread overview]
Message-ID: <20231108152401.432980-1-hch@lst.de> (raw)

The xfs_io command (only in Darricks trees and not upstream yet)
supports the -v switch to select the swapext version.  When the selected
swapext version is not supported it reports a 'version must be $foo'
message.  Parse that and don't _notfun the test cases.

This fixes various generic tests trying to use the vfs version that
doesn't exist in most branches implementing the swapext command.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 common/rc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/rc b/common/rc
index 26a26085..d8a0b19b 100644
--- a/common/rc
+++ b/common/rc
@@ -2706,6 +2706,8 @@ _require_xfs_io_command()
 			_notrun "xfs_io $command $param ioctl support is missing"
 		echo $testio | grep -q "Operation not supported" && \
 			_notrun "xfs_io $command $param kernel support is missing"
+		echo $testio | grep -q "version must" && \
+			_notrun "xfs_io $command $param kernel support is missing"
 		rm -f $testfile.1
 		param_checked="$param"
 		;;
-- 
2.39.2


             reply	other threads:[~2023-11-08 15:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08 15:24 Christoph Hellwig [this message]
2023-11-08 21:33 ` [PATCH] common: fix _require_xfs_io_command for specific swapext versions Darrick J. Wong
2023-11-08 21:44   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231108152401.432980-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox