From: David Disseldorp <ddiss@suse.de>
To: fstests@vger.kernel.org
Cc: Qu Wenruo <wqu@suse.com>, David Disseldorp <ddiss@suse.de>
Subject: [PATCH 5/5] btrfs/282: increase throttled scrub rate tolerance
Date: Thu, 7 Dec 2023 18:20:56 +1100 [thread overview]
Message-ID: <20231207072056.14588-6-ddiss@suse.de> (raw)
In-Reply-To: <20231207072056.14588-1-ddiss@suse.de>
Even with dmdelay injected latencies, I still observe occasional test
failures on shared storage (e.g. VMs). The extra 10% tolerance resolves
these intermittent failures on my system.
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
tests/btrfs/282 | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/btrfs/282 b/tests/btrfs/282
index 42d992a6..6649623a 100755
--- a/tests/btrfs/282
+++ b/tests/btrfs/282
@@ -95,9 +95,8 @@ speed=$($BTRFS_UTIL_PROG scrub status --raw $SCRATCH_MNT |\
tee -a $seqres.full |\
$AWK_PROG '$1 == "Rate:" {sub(/\/s/, "", $2); print $2}')
-# We gave a +- 10% tolerance for the throttle
-if [ "$speed" -gt "$(( $target_speed * 11 / 10 ))" -o \
- "$speed" -lt "$(( $target_speed * 9 / 10))" ]; then
+# We gave a +- 20% tolerance for the throttle
+if (( speed > target_speed * 12 / 10 || speed < target_speed * 8 / 10 )); then
echo "scrub speed $speed Bytes/s is not properly throttled, target is $target_speed Bytes/s"
fi
--
2.35.3
next prev parent reply other threads:[~2023-12-07 7:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 7:20 [PATCH 0/5] btrfs/282: resolve intermittent failures David Disseldorp
2023-12-07 7:20 ` [PATCH 1/5] common/dmdelay: remove DELAY_X enums David Disseldorp
2023-12-07 7:20 ` [PATCH 2/5] btrfs/282: append scrub status output to 282.full David Disseldorp
2023-12-07 9:46 ` Qu Wenruo
2023-12-07 7:20 ` [PATCH 3/5] btrfs/282: dmdelay scrub I/O to fix intermittent failures David Disseldorp
2023-12-07 7:20 ` [PATCH 4/5] btrfs/282: reduce scrub dataset size David Disseldorp
2023-12-07 7:20 ` David Disseldorp [this message]
2023-12-07 9:49 ` [PATCH 0/5] btrfs/282: resolve intermittent failures Qu Wenruo
2023-12-07 13:49 ` David Disseldorp
2023-12-07 20:02 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207072056.14588-6-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox