From: David Disseldorp <ddiss@suse.de>
To: Naohiro Aota <Naohiro.Aota@wdc.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] fstests: btrfs: use proper filter for subvolume deletion
Date: Fri, 22 Dec 2023 18:30:47 +1100 [thread overview]
Message-ID: <20231222183047.4dc7d8ba@echidna> (raw)
In-Reply-To: <zc6nx5hyhpticuwhcjiahbp67sjteqqehfhnrpk4kwvhyrwmq4@lf6uhzx6nst3>
On Fri, 22 Dec 2023 06:02:41 +0000, Naohiro Aota wrote:
> > > # Import common functions.
> > > . ./common/filter
> > > +. ./common/filter.btrfs
> >
> > common/filter.btrfs sources common/filter, so you can replace these.
>
> Oh, I didn't notice that. But, there are many test cases importing
> both. Maybe, it's good to express direct dependency (e.g, for
> _filter_scratch) explicitly? Or, they should be fixed as well?
I don't have a strong preference either way. I don't see any ordering
dependencies, so separate imports would also work.
Cheers, David
prev parent reply other threads:[~2023-12-22 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 2:56 [PATCH] fstests: btrfs: use proper filter for subvolume deletion Naohiro Aota
2023-12-22 5:07 ` David Disseldorp
2023-12-22 6:02 ` Naohiro Aota
2023-12-22 7:30 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222183047.4dc7d8ba@echidna \
--to=ddiss@suse.de \
--cc=Naohiro.Aota@wdc.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox