Re: [PATCH 01/10] generic/256: constrain runtime with TIME_FACTOR

Christoph Hellwig
2024-01-26T13:30:52Z

On Thu, Jan 25, 2024 at 11:04:14AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> This test runs 500 iterations of a "fill the fs and try to punch" test.
> Hole punching can be particularly slow if, say, the filesystem is
> mounted with -odiscard and the DISCARD operation takes a very long time.
> In extreme cases, I can see test runtimes of 4+ hours.
>
> Constrain the runtime of _test_full_fs_punch by establishing a deadline
> of (30 seconds * TIME_FACTOR) and breaking out of the for loop if the
> test goes beyond the time budget. This keeps the runtime within the
> customary 30 seconds.

Sounds good, this is can one of the slower 'quick' tests for sure:

Reviewed-by: Christoph Hellwig <hch@lst.de>