Re: [PATCH 0/4] btrfs: make test pass or skip them when using nodatacow

David Disseldorp
2024-02-05T12:29:54Z

On Thu, 1 Feb 2024 18:03:46 +0000, fdmanana@kernel.org wrote:

> From: Filipe Manana <fdmanana@suse.com>
>
> Several test btrfs test cases fail when using "-o nodatacow" in MOUNT_OPTIONS.
> So fix that by either adapting the tests to pass or skip them if there's no
> way for them to succeed in nodatacow mode.
>
> Filipe Manana (4):
> btrfs: require no nodatacow for tests that exercise compression
> btrfs/173: make the test work when mounting with nodatacow
> btrfs/299: skip test if we were mounted with nodatacow
> btrfs: require no nodatacow for tests that exercise read repair

The double negative hurts my eyes, but these all look fine to me (one
minor nit in 2/4).

Reviewed-by: David Disseldorp <ddiss@suse.de>