From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH -v2 1/2] ext4/045: use the large_dir feature to fix test failures with a 1k block size
Date: Tue, 11 Jun 2024 18:26:58 -0400 [thread overview]
Message-ID: <20240611222659.256476-1-tytso@mit.edu> (raw)
If the file system has a 1k blocksize, this test will fail without the
large_dir file system, because the depth of the dir_index tree needs
to be greater than 2. So enable the large_dir unconditionally, which
also gives us better test coverage of the large_dir code paths.
As a result of requiring large_dir, this test will get skipped if the
kernel is older than 4.13 --- which was released in 2017; and that
seems to be reasonable at this point.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
tests/ext4/045 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/ext4/045 b/tests/ext4/045
index 4f0ad4aa7..a90ae1ba3 100755
--- a/tests/ext4/045
+++ b/tests/ext4/045
@@ -20,6 +20,7 @@ LONG_DIR=2
_supported_fs ext4
_require_scratch
+_require_scratch_ext4_feature large_dir
_require_test_program "t_create_short_dirs"
_require_test_program "t_create_long_dirs"
_require_dumpe2fs
@@ -42,7 +43,7 @@ workout()
echo "Num of dirs to create: $1, Dir name len: $dir_name_len, " \
"Parent dir: $3" >> $seqres.full
- _scratch_mkfs "-O extent,dir_nlink,dir_index -I 256" >> $seqres.full 2>&1
+ _scratch_mkfs "-O extent,dir_nlink,dir_index,large_dir -I 256" >> $seqres.full 2>&1
_scratch_mount
# create directories
--
2.43.0
next reply other threads:[~2024-06-11 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 22:26 Theodore Ts'o [this message]
2024-06-11 22:26 ` [PATCH -v2 2/2] generic/455: skip the test if the file system doesn't support journaling Theodore Ts'o
2024-06-17 7:41 ` Zorro Lang
2024-06-17 7:26 ` [PATCH -v2 1/2] ext4/045: use the large_dir feature to fix test failures with a 1k block size Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611222659.256476-1-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox