Re: [PATCH 1/1] xfs: test scaling of the mkfs concurrency options

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Jun 18, 2024 at 11:24:25PM -0700, Christoph Hellwig wrote:
> On Mon, Jun 17, 2024 at 05:46:45PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Make sure that the AG count and log size scale up with the new
> > concurrency options to mkfs.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> >  tests/xfs/1842             |   55 ++++++++++++++
> >  tests/xfs/1842.cfg         |    4 +
> >  tests/xfs/1842.out.lba1024 |  177 ++++++++++++++++++++++++++++++++++++++++++++
> >  tests/xfs/1842.out.lba2048 |  177 ++++++++++++++++++++++++++++++++++++++++++++
> >  tests/xfs/1842.out.lba4096 |  177 ++++++++++++++++++++++++++++++++++++++++++++
> >  tests/xfs/1842.out.lba512  |  177 ++++++++++++++++++++++++++++++++++++++++++++
> >  6 files changed, 767 insertions(+)
> >  create mode 100755 tests/xfs/1842
> >  create mode 100644 tests/xfs/1842.cfg
> >  create mode 100644 tests/xfs/1842.out.lba1024
> >  create mode 100644 tests/xfs/1842.out.lba2048
> >  create mode 100644 tests/xfs/1842.out.lba4096
> >  create mode 100644 tests/xfs/1842.out.lba512
> > 
> > 
> > diff --git a/tests/xfs/1842 b/tests/xfs/1842
> > new file mode 100755
> > index 0000000000..8180ca7a6e
> > --- /dev/null
> > +++ b/tests/xfs/1842
> > @@ -0,0 +1,55 @@
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2022-2024 Oracle.  All Rights Reserved.
> > +#
> > +# FS QA Test No. 1842
> > +#
> > +# mkfs concurrency test - ensure the log and agsize scaling works for various
> > +# concurrency= parameters
> > +#
> > +. ./common/preamble
> > +_begin_fstest log metadata auto quick
> > +
> > +# Import common functions.
> > +. ./common/filter
> > +. ./common/reflink
> > +
> > +_cleanup()
> > +{
> > +	cd /
> > +	rm -r -f $tmp.* $loop_file
> > +}
> > +
> > +# real QA test starts here
> > +_supported_fs xfs
> > +
> > +_require_test
> > +_require_loop
> > +$MKFS_XFS_PROG 2>&1 | grep -q concurrency || \
> > +	_notrun "mkfs does not support concurrency options"
> > +
> > +test_dev_lbasize=$(blockdev --getss $TEST_DEV)
> > +seqfull=$0
> > +_link_out_file "lba${test_dev_lbasize}"
> 
> This should probably check for an lba size that doesn't have valid
> golden output instead of having a weird failure case?  Not really
> an issue right now, but it will be one with the large lba size work.

Weird failure case?  If we don't have an output file to link, fstests
spits out:

1842.lba268433408: could not setup output file

That said, Bill's patch to fix u64 truncation in the log concurrency
computation means the .out files in this patch are buggy, so I'll respin
this patch.

--D