From: "Darrick J. Wong" <djwong@kernel.org>
To: Long Li <leo.lilong@huawei.com>
Cc: zlang@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, yi.zhang@huawei.com, houtao1@huawei.com,
yangerkun@huawei.com
Subject: Re: [PATCH 1/2] xfs/016: fix test fail when head equal to near_end_min
Date: Fri, 12 Jul 2024 08:38:14 -0700 [thread overview]
Message-ID: <20240712153814.GT612460@frogsfrogsfrogs> (raw)
In-Reply-To: <20240712064716.3385793-1-leo.lilong@huawei.com>
On Fri, Jul 12, 2024 at 02:47:15PM +0800, Long Li wrote:
> xfs/016 checks for corruption in the log when it wraps. It looks for a log
> head that is at or above the minimum log size. If the final position of
> the log head equals near_end_min, the test will fail. Under these
> conditions, we should let the test continue.
>
> Signed-off-by: Long Li <leo.lilong@huawei.com>
> ---
> tests/xfs/016 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/016 b/tests/xfs/016
> index 6337bb1f..335a2d61 100755
> --- a/tests/xfs/016
> +++ b/tests/xfs/016
> @@ -239,7 +239,7 @@ while [ $head -lt $near_end_min ]; do
> head=$(_log_head)
> done
>
> -[ $head -gt $near_end_min -a $head -lt $log_size_bb ] || \
> +[ $head -ge $near_end_min -a $head -lt $log_size_bb ] || \
Heh, that's quite the coincidence!
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> _fail "!!! unexpected near end log position $head"
>
> # Step 4: Try to wrap the log, checking for corruption with each advance.
> --
> 2.39.2
>
>
prev parent reply other threads:[~2024-07-12 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 6:47 [PATCH 1/2] xfs/016: fix test fail when head equal to near_end_min Long Li
2024-07-12 6:47 ` [PATCH 2/2] xfs/242: fix test failure due to incorrect filtering in _filter_bmap Long Li
2024-07-12 15:39 ` Darrick J. Wong
2024-07-12 15:38 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712153814.GT612460@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=houtao1@huawei.com \
--cc=leo.lilong@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox