From: Matthew Broomfield <mattysweeps@google.com>
To: Zorro Lang <zlang@kernel.org>
Cc: Matthew Broomfield <mattysweeps@google.com>, fstests@vger.kernel.org
Subject: [PATCH] generic/375: clarify flipping the write bit
Date: Thu, 1 Aug 2024 23:04:18 +0000 [thread overview]
Message-ID: <20240801230417.323994-2-mattysweeps@google.com> (raw)
When checking if SGID is cleared upon chmod / setfacl the write bit is
flipped just to make sure permission changes are happening. This is
orthogonal to testing SGID.
Added this information to the test description.
Signed-off-by: Matthew Broomfield <mattysweeps@google.com>
---
tests/generic/375 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/generic/375 b/tests/generic/375
index eb675144..44670350 100755
--- a/tests/generic/375
+++ b/tests/generic/375
@@ -7,6 +7,9 @@
# Check if SGID is cleared upon chmod / setfacl when the owner is not in the
# owning group.
#
+# The test flips the write bit to easily observe that chmod / setfacl are
+# successful. This is unrelated to testing SGID.
+#
. ./common/preamble
_begin_fstest auto quick acl perms
--
2.46.0.rc2.264.g509ed76dc8-goog
next reply other threads:[~2024-08-01 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 23:04 Matthew Broomfield [this message]
2024-09-14 20:18 ` [PATCH] generic/375: clarify flipping the write bit Matthew Broomfield
2024-09-16 21:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801230417.323994-2-mattysweeps@google.com \
--to=mattysweeps@google.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox