From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 3/5] xfs/424: don't use _min_dio_alignment
Date: Wed, 14 Aug 2024 06:52:12 +0200 [thread overview]
Message-ID: <20240814045232.21189-4-hch@lst.de> (raw)
In-Reply-To: <20240814045232.21189-1-hch@lst.de>
xfs/424 tests xfs_db and not the kernel xfs code, and really wants
the device sector size and not the minimum direct I/O alignment.
Switch to a direct call of the blockdev utility.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---
tests/xfs/424 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/424 b/tests/xfs/424
index 71d48bec1..6078d3489 100755
--- a/tests/xfs/424
+++ b/tests/xfs/424
@@ -50,7 +50,7 @@ echo "Silence is golden."
# NOTE: skip attr3, bmapbta, bmapbtd, dir3, dqblk, inodata, symlink
# rtbitmap, rtsummary, log
#
-sec_sz=`_min_dio_alignment $SCRATCH_DEV`
+sec_sz=`blockdev --getss $SCRATCH_DEV`
while [ $sec_sz -le 4096 ]; do
sector_sizes="$sector_sizes $sec_sz"
sec_sz=$((sec_sz * 2))
--
2.43.0
next prev parent reply other threads:[~2024-08-14 4:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 4:52 improve minalign handling v2 Christoph Hellwig
2024-08-14 4:52 ` [PATCH 1/5] statx.h: update to latest kernel UAPI Christoph Hellwig
2024-08-14 5:12 ` Darrick J. Wong
2024-08-14 4:52 ` [PATCH 2/5] add a new min_dio_alignment helper Christoph Hellwig
2024-08-14 5:12 ` Darrick J. Wong
2024-09-10 17:09 ` Eric Biggers
2024-08-14 4:52 ` Christoph Hellwig [this message]
2024-08-14 4:52 ` [PATCH 4/5] generic: don't use _min_dio_alignment without a device argument Christoph Hellwig
2024-08-14 4:52 ` [PATCH 5/5] replace _min_dio_alignment with calls to src/min_dio_alignment Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-08-13 7:34 improve minalign handling Christoph Hellwig
2024-08-13 7:35 ` [PATCH 3/5] xfs/424: don't use _min_dio_alignment Christoph Hellwig
2024-08-13 14:40 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814045232.21189-4-hch@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox