From: "André Almeida" <andrealmeid@igalia.com>
To: fstests@vger.kernel.org
Cc: "Zorro Lang" <zlang@kernel.org>,
kernel-dev@igalia.com, "Miklos Szeredi" <mszeredi@redhat.com>,
"Eryu Guan" <guaneryu@gmail.com>,
"André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH] common/config: Correctly ignore {TEST|SCRATCH}_DEV for tmpfs
Date: Wed, 21 Aug 2024 12:57:46 -0300 [thread overview]
Message-ID: <20240821155746.55828-1-andrealmeid@igalia.com> (raw)
As per commit 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV"),
tmpfs doesn't need TEST or SCRATCH devices due to being a RAM-based
filesystem.
Fix the check by comparing the content of the variable TEST_DEV, instead
of comparing with the string TEST_DEV. Same for SCRATCH_DEV.
Fixes: 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV")
Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
common/config | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/config b/common/config
index 22740c0a..307f93fb 100644
--- a/common/config
+++ b/common/config
@@ -829,10 +829,10 @@ get_next_config() {
fi
if [ "$FSTYP" == "tmpfs" ]; then
- if [ -z "TEST_DEV" ]; then
+ if [ -z "$TEST_DEV" ]; then
export TEST_DEV=tmpfs_test
fi
- if [ -z "SCRATCH_DEV" ]; then
+ if [ -z "$SCRATCH_DEV" ]; then
export TEST_DEV=tmpfs_scratch
fi
fi
--
2.46.0
next reply other threads:[~2024-08-21 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 15:57 André Almeida [this message]
2024-08-21 17:12 ` [PATCH] common/config: Correctly ignore {TEST|SCRATCH}_DEV for tmpfs Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821155746.55828-1-andrealmeid@igalia.com \
--to=andrealmeid@igalia.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=kernel-dev@igalia.com \
--cc=mszeredi@redhat.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox