Re: [PATCH] generic/694: sync before sampling i_blocks

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Oct 08, 2024 at 09:12:09AM +0200, Christoph Hellwig wrote:
> Without a sync there might still be temporary blocks in i_blocks like
> indirect block reservations or additional blocks reserved for out of
> place writes.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/694 | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/generic/694 b/tests/generic/694
> index 02253ef75..b6bc8a75f 100755
> --- a/tests/generic/694
> +++ b/tests/generic/694
> @@ -37,6 +37,10 @@ if [ $? -ne 0 ]; then
>  	echo "Could not create 4G test file"
>  fi
>  
> +# make sure indirect block reservations and other temporary block reservations
> +# are release before sampling i_blocks

Nit: '...are released before...'

> +sync

Should this be more targeted since we only care about junk_file's
i_blocks, not flushing everything in the system. e.g.

sync $junk_file

--D

> +
>  iblocks=`stat -c '%b' $junk_file`
>  
>  _test_cycle_mount
> -- 
> 2.45.2
> 
>