FS/XFS testing framework
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH -v2] xfs/32: fix test failure on kernels which don't support bs > ps
Date: Mon, 20 Jan 2025 22:33:56 -0500	[thread overview]
Message-ID: <20250121033356.GB3761769@mit.edu> (raw)
In-Reply-To: <20250121023536.dz45c3ustuk3fddu@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>

On Tue, Jan 21, 2025 at 10:35:36AM +0800, Zorro Lang wrote:
> On Mon, Jan 20, 2025 at 12:01:09PM -0500, Theodore Ts'o wrote:
> > When trying to mount a file system with a block size > page size on
> > kernel which doesn't support this, suppress the error messages from
> > showing up in the output file lest it cause test failures.
> > 
> > Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > ---
> > v2:
> >     As Darrick suggested redirect the output of mount(8) to $seqres.full
> >     instead of /dev/null
> 
> Thanks for fixing it.
> 
> Reviewed-by: Zorro Lang <zlang@redhat.com>

I just noticed just now that I screwed up the subject line / commit description.

xfs/32: ...

should be:

xfs/032: ...

Sorry for not noticing this earlier!

					- Ted

  reply	other threads:[~2025-01-21  3:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17 19:06 [PATCH] xfs/32: fix test failure on kernels which don't support bs > ps Theodore Ts'o
2025-01-17 21:02 ` Darrick J. Wong
2025-01-20 17:01   ` [PATCH -v2] " Theodore Ts'o
2025-01-21  2:35     ` Zorro Lang
2025-01-21  3:33       ` Theodore Ts'o [this message]
2025-01-21  5:12         ` Zorro Lang
2025-01-21 15:59     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250121033356.GB3761769@mit.edu \
    --to=tytso@mit.edu \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox